Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

skip flaky test #21981

Merged
merged 1 commit into from Mar 12, 2019
Merged

skip flaky test #21981

merged 1 commit into from Mar 12, 2019

Conversation

balloob
Copy link
Member

@balloob balloob commented Mar 12, 2019

Description:

This test is flaky.

@homeassistant homeassistant added small-pr PRs with less than 30 lines. cla-signed labels Mar 12, 2019
@ghost ghost assigned balloob Mar 12, 2019
@ghost ghost added the in progress label Mar 12, 2019
@balloob balloob merged commit f8921f8 into dev Mar 12, 2019
@ghost ghost removed the in progress label Mar 12, 2019
@delete-merged-branch delete-merged-branch bot deleted the skip-flaky-test branch March 12, 2019 21:19
@awarecan
Copy link
Contributor

I thought I fixed it few days ago. Is it still flaky?

@balloob
Copy link
Member Author

balloob commented Mar 13, 2019

I had it failing in a PR . I can't find the log anymore. Maybe it was a PR that wasn't rebased? Shall I revert?

@balloob balloob mentioned this pull request Mar 20, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MartinHjelmare MartinHjelmare MartinHjelmare approved these changes

Assignees

@balloob balloob

Labels
cla-signed small-pr PRs with less than 30 lines.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@balloob @awarecan @MartinHjelmare @homeassistant