Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix hlk-sw16 inverted switch state #22059

Merged
merged 1 commit into from Mar 18, 2019
Merged

Fix hlk-sw16 inverted switch state #22059

merged 1 commit into from Mar 18, 2019

Conversation

jameshilliard
Copy link
Contributor

Description:

Related issue (if applicable): fixes #19900 and #21956

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.

If the code communicates with devices, web services, or third-party tools:

  • New dependencies have been added to the REQUIREMENTS variable ([example][ex-requir]).
  • New dependencies are only imported inside functions that use them ([example][ex-import]).
  • New or updated dependencies have been added to requirements_all.txt by running script/gen_requirements_all.py.
  • New files were added to .coveragerc.

@ghost ghost added the in progress label Mar 15, 2019
This was referenced Mar 15, 2019
Closed
Closed
cgtobi
cgtobi approved these changes Mar 15, 2019
View reviewed changes
Copy link
Contributor

@cgtobi cgtobi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@awarecan
Copy link
Contributor

Test fail caused by a known issue that has been resolved in dev branch, this PR is good for merge.

@awarecan awarecan merged commit 9c7ef13 into home-assistant:dev Mar 18, 2019
@ghost ghost removed the in progress label Mar 18, 2019
@balloob balloob mentioned this pull request Apr 3, 2019
Merged
@jameshilliard jameshilliard deleted the hlk-sw16 branch November 17, 2023 08:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cgtobi cgtobi cgtobi approved these changes

Assignees
No one assigned
Labels
cla-signed integration: hlk_sw16 small-pr PRs with less than 30 lines.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Hi-Link HLK-SW16 state is inverted.
4 participants
@jameshilliard @awarecan @cgtobi @homeassistant