New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Consolidate the netgear_lte configuration #22105
Merged
MartinHjelmare
merged 4 commits into
home-assistant:dev
from
amelchio:netgear_lte-embedded-config
Mar 22, 2019
Merged
Consolidate the netgear_lte configuration #22105
MartinHjelmare
merged 4 commits into
home-assistant:dev
from
amelchio:netgear_lte-embedded-config
Mar 22, 2019
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned amelchio
Mar 16, 2019
ghost
added
the
in progress
label
Mar 16, 2019
This was referenced Mar 20, 2019
Documentation updated. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just some small comments.
MartinHjelmare
approved these changes
Mar 22, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice!
Thanks for being so careful, it really improved things 🥳 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Breaking Change:
The
netgear_lte
configuration has been consolidated undernetgear_lte:
, check the documentation for more information.Description:
Notes:
sensors
will set up an unspecified set of default sensors.notify
will set up a notify servicenotify.netgear_lte
with no default recipient.target
has been renamedrecipient
(fixes Use CONF_RECIPIENT for default recipient in config #20670).scan_interval
.This should hopefully support the next PRs that I am planning:
Pull request in home-assistant.io with documentation (if applicable): home-assistant/home-assistant.io#9000
Example entry for
configuration.yaml
:(The following snippets are both needleesly verbose in order to cover more situations)
Before:
Now:
Checklist:
tox
.If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
REQUIREMENTS
variable ([example][ex-requir]).requirements_all.txt
by runningscript/gen_requirements_all.py
..coveragerc
.