Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added component named switcher_kis switcher water heater integration. #22325
Added component named switcher_kis switcher water heater integration. #22325
Changes from 35 commits
fbbbced
5d2044f
4820ba6
17cef18
cb00473
8aaa421
bb21856
6ee2968
d0391d7
c9f28a5
e70407e
d65ed8f
0736cf1
26815c8
d62f99f
38619e8
011dd16
f778981
6a50f3f
3495e05
0bd8b08
e7b2330
c4441c8
8babc45
de6a41f
105df9f
b1c68d9
dccbe44
6709f09
77458d1
5237b97
a53ee0d
f3812d3
c18e742
c518dc4
cb7ab11
02704fb
f63e694
5b30d84
0557f5a
e26245e
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We shouldn't use
hass.async_add_job
anymore. It's legacy.Why do we need to add a job for this at all?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@MartinHjelmare
Much appreciated!
I addressed this and the other issues you referenced in a new PR I'm currently working on.
I'll notify you once I'll create the new pull request.
Thank you very much.
:-)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The new PR is here.
Besides resolving all the change requests from this PR, it also adds a couple of services and update the requirement version.
:-)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We start logging messages with capital letter.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pass en emtpy dict as discovery_info, ie fourth argument.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Instead check if discovery_info is None and return if so.