Introducing support for Netatmo Welcome Camera #2233

jabesq · 2016-06-04T11:47:42Z

Description:
This change is introducing two things:

Global component for Netatmo devices: it allows to share credentials between Netatmo Weather Station, Welcome camera and also for Thermosat (even if not supported yet)
Support for Netatmo Welcome Camera: Currently it only provides the live feed of the camera. The final goal will be to also to use this camera as a binary sensor and a device tracker

Related issue (if applicable): fixes #

Pull request in home-assistant.io with documentation (if applicable): home-assistant/home-assistant.io#542

Example entry for configuration.yaml (if applicable):

#Netatmo Component
netatmo:
    api_key: API_KEY
    secret_key: SECRET_KEY
    username: username
    password: password

#Cameras
camera:
    platform: netatmo
    home: home_name (Optional)
    cameras: (Optional)
        - camera_name1
        - camera_name2

sensor:
  platform: netatmo
  modules:
    module_name1:
      - temperature
      - humidity
      - noise
      - pressure
      - co2
      - rain
      - sum_rain_1
      - sum_rain_24
    module_name2:
      - temperature
    rainmeter_name3:
      - rain
      - sum_rain_1
      - sum_rain_24

Checklist:

If user exposed functionality or configuration variables are added/changed:

Documentation added/updated in home-assistant.io

If code communicates with devices:

Local tests with tox run successfully. Your PR cannot be merged unless tests pass
New dependencies have been added to the REQUIREMENTS variable (example).
New dependencies are only imported inside functions that use them (example).
New dependencies have been added to requirements_all.txt by running script/gen_requirements_all.py.
New files were added to .coveragerc.

If the code does not interact with devices:

Local tests with tox run successfully. Your PR cannot be merged unless tests pass
Tests have been added to verify that the new code works.

balloobbot · 2016-06-04T11:48:28Z

homeassistant/components/camera/netatmo.py

+        add_devices_callback([WelcomeCamera(data, camera_name, home)])
+
+
+class WelcomeCamera(Camera):


farcy v1.1

D200: One-line docstring should fit on one line with quotes (found 3)

I don't get it what you want here @balloobbot

rmkraus · 2016-06-04T19:15:32Z

Is it possible to have the Netatmo component search for the cameras and sensors then create what is found? Take a look at the Hue component, it does this.

jabesq · 2016-06-04T19:30:45Z

It already works like this for the camera (but I detail on the documentation how to filter for a specific camera if the user has several and want to display only one)
For the sensor, I just kept the behavior of the current netatmo sensor. The only change is that credentials are now stored inside a new global component Netatmo

rmkraus · 2016-06-04T19:36:35Z

Great! 👍

Maybe a later PR could cover discovery of Netatmo sensors, but that would definitely be too much for one PR.

rmkraus · 2016-06-04T19:38:06Z

homeassistant/components/camera/netatmo.py

@@ -0,0 +1,98 @@
+"""
+Support for the NetAtmo Weather Service.


This looks like it needs a quick update 😉

rmkraus · 2016-06-04T20:01:42Z

Looks really good. I had a few nitpicky docstring comments (sorry) and a few more questions.

In particular, how will the camera and sensor platforms react when improper credentials are provided? They don't seem to individually check to ensure that these credentials are good. Especially since this would be a breaking change, the platforms should probably put good information in the logs.

Now that I'm typing, what if the sensors platform still accepted the credentials, as is it did before, but threw a deprecation warning to the log? That all helps ease the transition of breaking changes.

As Netatmo is providing several type of device (sensor, camera), a new Netatmo component needs to be created in order to centralize the Netatmo login data. Currently this change only impacts the Netatmo Weather station

This new API will provide access to the Welcome Camera

This change introduces support for Netatmo Welcome camera. Currently, it will add all detected camera to Home Assistant, camera filtering (similar to the one used for weather station modules) will be added later

balloob · 2016-06-09T04:28:15Z

homeassistant/components/camera/netatmo.py

+                self.camera_names.append(camera['name'])
+        return self.camera_names
+
+    def update(self):


You should throttle this call, otherwise it will be called once for each camera that is failing inside camera_image.

As the update function updates the data for all cameras, we should prevent this function to be called several time during an interval

balloob · 2016-06-10T06:31:40Z

Looks good! 🐬

balloob · 2016-09-10T14:43:54Z

@jabesq it looks like you deleted the 0.5 release of the Python Netatmo lib that you had Home Assistant point at for this PR, breaking Home Assistant. What's going on ?

jabesq · 2016-09-10T16:27:48Z

Ooops, I did a force rebase on philipelt's netatmo API (which has credentials to the pypi archive) as I plan to retake my work for the Welcome camera but my rebase might have delete my tag, I'll recreate it so home-assistant can find it again. But my goal was that home-assistant to use directly the pypi archive.

balloobbot reviewed Jun 4, 2016
View reviewed changes

jabesq force-pushed the netatmo branch 5 times, most recently from 298664b to 3f50226 Compare June 4, 2016 12:38

rmkraus reviewed Jun 4, 2016
View reviewed changes

jabesq force-pushed the netatmo branch 6 times, most recently from 389bfff to 6f733af Compare June 6, 2016 08:19

jabesq mentioned this pull request Jun 6, 2016

Add Documentation for Netatmo Welcome home-assistant/home-assistant.io#534

Closed

jabesq added 7 commits June 6, 2016 17:48

Introducing the Netatmo component

9307adf

As Netatmo is providing several type of device (sensor, camera), a new Netatmo component needs to be created in order to centralize the Netatmo login data. Currently this change only impacts the Netatmo Weather station

Add new Netatmo library

efbf49e

This new API will provide access to the Welcome Camera

Basic support for Netatmo Welcome camera

0ae0377

This change introduces support for Netatmo Welcome camera. Currently, it will add all detected camera to Home Assistant, camera filtering (similar to the one used for weather station modules) will be added later

Remove useless REQUIREMENTS

bd82169

Fixes for Netatmo Welcome support

8c4e4f2

Allow to filter Welcome cameras by name and/or home

e4d2688

Update requirements for Netatmo components

56e9093

jabesq added 2 commits June 6, 2016 17:48

Fix multi-camera support for Welcome

b38c81a

Fix pep8 error/warning

7aacffb

jabesq force-pushed the netatmo branch from 6f733af to f85e520 Compare June 6, 2016 15:48

jabesq mentioned this pull request Jun 8, 2016

Add Documentation for Netatmo Welcome home-assistant/home-assistant.io#542

Merged

balloob reviewed Jun 9, 2016
View reviewed changes

This commit also adds improved logging for bad credentials

d55d9c6

jabesq force-pushed the netatmo branch from f85e520 to d55d9c6 Compare June 9, 2016 08:21

Add Throttle decorator for Welcome update function

e8fef87

As the update function updates the data for all cameras, we should prevent this function to be called several time during an interval

jabesq force-pushed the netatmo branch from 9c40797 to e8fef87 Compare June 9, 2016 09:10

balloob merged commit 213a738 into home-assistant:dev Jun 10, 2016

jabesq deleted the netatmo branch June 10, 2016 08:36

fabaff mentioned this pull request Sep 11, 2016

Use voluptuous for netatmo #3287

Merged

home-assistant locked and limited conversation to collaborators Mar 17, 2017

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Introducing support for Netatmo Welcome Camera #2233

Introducing support for Netatmo Welcome Camera #2233

jabesq commented Jun 4, 2016 •

edited by balloob

balloobbot Jun 4, 2016

jabesq Jun 6, 2016

rmkraus commented Jun 4, 2016

jabesq commented Jun 4, 2016

rmkraus commented Jun 4, 2016

rmkraus Jun 4, 2016

rmkraus commented Jun 4, 2016

balloob Jun 9, 2016

balloob commented Jun 10, 2016

balloob commented Sep 10, 2016

jabesq commented Sep 10, 2016

		add_devices_callback([WelcomeCamera(data, camera_name, home)])


		class WelcomeCamera(Camera):

Introducing support for Netatmo Welcome Camera #2233

Introducing support for Netatmo Welcome Camera #2233

Conversation

jabesq commented Jun 4, 2016 • edited by balloob

balloobbot Jun 4, 2016

Choose a reason for hiding this comment

jabesq Jun 6, 2016

Choose a reason for hiding this comment

rmkraus commented Jun 4, 2016

jabesq commented Jun 4, 2016

rmkraus commented Jun 4, 2016

rmkraus Jun 4, 2016

Choose a reason for hiding this comment

rmkraus commented Jun 4, 2016

balloob Jun 9, 2016

Choose a reason for hiding this comment

balloob commented Jun 10, 2016

balloob commented Sep 10, 2016

jabesq commented Sep 10, 2016

jabesq commented Jun 4, 2016 •

edited by balloob