New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove pycryptodome requirement for Android TV #22552
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, but supporting library must be released first
I know, I just want to make sure that this works as expected before publishing |
@dgomes the tests should pass, and it does say:
But 5 tests say they are still expected. Is this a bug with Circle CI? Or do I need to rebase? Or is it something else??? |
We are undergoing major code rebase, I would advise you to rebase. |
Am I supposed to modify the manifest.json file? Should I do that in a separate PR so that this PR can get merged into the 0.91.1 release? |
Could we please merge this in so that #22726 can be closed. And if there's going to be a 0.91.2 release, it would be nice if this fix could be included. |
Thanks, @dgomes! |
* Bump androidtv to 0.0.15 * Bump androidtv to 0.0.15 in manifest.json
Description:
This removes the
pycryptodome
requirement fromandroidtv
.Originally, I wanted to implement the
set_volume_method
, but this proved to be more difficult than expected, so I changed the focus of this pull request.Fixes issue: #22726, #22769
Checklist:
tox
. Your PR cannot be merged unless tests passIf the code communicates with devices, web services, or third-party tools:
REQUIREMENTS
variable ([example][ex-requir]).requirements_all.txt
by runningscript/gen_requirements_all.py
.