Return 0 for failed Foscam streams #22651
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
homeassistant
added
integration: foscam
small-pr
ghost
added
the
9 tasks
hunterjm
requested changes
Apr 2, 2019
balloob
approved these changes
Apr 2, 2019
balloob
pushed a commit
that referenced
this pull request
Apr 2, 2019
* Update Foscam to support stream source * Removing spaces and tabs * Changing to Python3-style string formatting * Adding '_media_port' to hopefully cover other models * changing logic for success and return none
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
An error was being thrown if a camera was defined in the config but unreachable. This prevents the error from being thrown and returns 0 for SUPPORT_STREAM and stream_source.
Related issue (if applicable): fixes #22568
Checklist:
tox. Your PR cannot be merged unless tests passIf the code does not interact with devices: