Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Return 0 for failed Foscam streams #22651

Merged
merged 8 commits into from Apr 2, 2019

Conversation

Projects
None yet
4 participants
@cwhits
Copy link
Contributor

commented Apr 2, 2019

Description:

An error was being thrown if a camera was defined in the config but unreachable. This prevents the error from being thrown and returns 0 for SUPPORT_STREAM and stream_source.

Related issue (if applicable): fixes #22568

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.

If the code does not interact with devices:

  • Tests have been added to verify that the new code works.

@ghost ghost added the in progress label Apr 2, 2019

@cwhits cwhits changed the title Foscam Return 0 for failed Foscam streams Apr 2, 2019

@cwhits cwhits referenced this pull request Apr 2, 2019

Merged

Update Foscam component to support stream source #22568

1 of 9 tasks complete
Show resolved Hide resolved homeassistant/components/foscam/camera.py Outdated
Show resolved Hide resolved homeassistant/components/foscam/camera.py Outdated
@balloob

balloob approved these changes Apr 2, 2019

@balloob balloob added this to the 0.91.0 milestone Apr 2, 2019

@balloob balloob merged commit 429e2cd into home-assistant:dev Apr 2, 2019

12 checks passed

Hound No violations found. Woof!
build Workflow: build
Details
ci/circleci: pre-install-all-requirements Your tests passed on CircleCI!
Details
ci/circleci: pre-test 3.5.5 Your tests passed on CircleCI!
Details
ci/circleci: pre-test 3.6 Your tests passed on CircleCI!
Details
ci/circleci: pre-test 3.7 Your tests passed on CircleCI!
Details
ci/circleci: pylint Your tests passed on CircleCI!
Details
ci/circleci: static-check Your tests passed on CircleCI!
Details
ci/circleci: test 3.5.5 Your tests passed on CircleCI!
Details
ci/circleci: test 3.6 Your tests passed on CircleCI!
Details
ci/circleci: test 3.7 Your tests passed on CircleCI!
Details
cla-bot Everyone involved has signed the CLA

@ghost ghost removed the in progress label Apr 2, 2019

balloob added a commit that referenced this pull request Apr 2, 2019

Return 0 for failed Foscam streams (#22651)
* Update Foscam to support stream source

* Removing spaces and tabs

* Changing to Python3-style string formatting

* Adding '_media_port' to hopefully cover other models

* changing logic for success and return none

mxworm added a commit to mxworm/home-assistant that referenced this pull request Apr 2, 2019

Merge branch 'dev' into current
* dev: (203 commits)
  Add color support to emulated hue (home-assistant#19590)
  Add missing properties and scenes support to Osram Lightify (home-assistant#22597)
  Axis discovery updates host address (home-assistant#22632)
  Add battery sensor to Homematic IP (home-assistant#22630)
  Return 0 for failed Foscam streams (home-assistant#22651)
  Ignore code coverages for component without test (home-assistant#22653)
  Admin service to automatically add empty schema (home-assistant#22637)
  Fix pytest durations parameter (home-assistant#22658)
  Don't force updates on ZHA Electrical Measurement sensor. (home-assistant#22647)
  Improve evohome exception handling and fix bugs (home-assistant#22140)
  Fix racy homekit_controller platform setup caused by home-assistant#22368 (home-assistant#22655)
  Run PyLint under Python 3.5 (home-assistant#22642)
  Qwikswitch fix listen loop (home-assistant#22600)
  Add codecov (home-assistant#22649)
  Add trusted networks deprecating warning (home-assistant#22487)
  Require static-check success first for rest of workflow (home-assistant#22635)
  Support GET params for websocket ingress path (home-assistant#22638)
  change library to georss_generic_client (home-assistant#22615)
  Amcrest: Add on/off support & attributes. Bump amcrest to 1.3.0 (home-assistant#22418)
  Add support for Dyson Purecool 2018 Air Purifiers models TP04 and DP04 (home-assistant#22215)
  ...

@balloob balloob referenced this pull request Apr 3, 2019

Merged

0.91.0 #22688

unibeck pushed a commit to unibeck/home-assistant that referenced this pull request Apr 7, 2019

Return 0 for failed Foscam streams (home-assistant#22651)
* Update Foscam to support stream source

* Removing spaces and tabs

* Changing to Python3-style string formatting

* Adding '_media_port' to hopefully cover other models

* changing logic for success and return none
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.