Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add deprecation warning to embedded MQTT broker #22753

Merged
merged 1 commit into from Apr 5, 2019

Conversation

emontnemery
Copy link
Contributor

Description:

Add deprecation warning if embedded broker is configured, background in home-assistant/architecture#186

Pull request in home-assistant.io with documentation (if applicable): home-assistant/home-assistant.io#TODO

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.

If user exposed functionality or configuration variables are added/changed:

@emontnemery emontnemery requested a review from a team as a code owner April 5, 2019 06:04
@ghost ghost assigned emontnemery Apr 5, 2019
@ghost ghost added the in progress label Apr 5, 2019
@emontnemery emontnemery changed the title Add deprecation warning to embedded broker Add deprecation warning to embedded MQTT broker Apr 5, 2019
@github-actions
Copy link

github-actions bot commented Apr 5, 2019

Hey there @home-assistant/core, mind taking a look at this pull request as its been labeled with a integration (mqtt) you are listed as a codeowner for? Thanks!

@codecov
Copy link

codecov bot commented Apr 5, 2019

Codecov Report

Merging #22753 into dev will increase coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev   #22753      +/-   ##
==========================================
+ Coverage   93.83%   93.83%   +<.01%     
==========================================
  Files         448      449       +1     
  Lines       36524    36568      +44     
==========================================
+ Hits        34271    34315      +44     
  Misses       2253     2253
Impacted Files Coverage Δ
homeassistant/components/zha/binary_sensor.py 90.47% <0%> (-1.91%) ⬇️
homeassistant/components/deconz/switch.py 100% <0%> (ø) ⬆️
homeassistant/components/darksky/sensor.py 97.72% <0%> (ø) ⬆️
homeassistant/components/deconz/binary_sensor.py 91.66% <0%> (ø) ⬆️
homeassistant/components/deconz/deconz_device.py 100% <0%> (ø) ⬆️
homeassistant/components/deconz/climate.py 98.18% <0%> (ø) ⬆️
homeassistant/components/deconz/scene.py 100% <0%> (ø) ⬆️
homeassistant/components/deconz/cover.py 100% <0%> (ø) ⬆️
homeassistant/components/deconz/const.py 100% <0%> (ø) ⬆️
homeassistant/components/deconz/light.py 100% <0%> (ø) ⬆️
... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8b77298...3286e27. Read the comment docs.

@balloob balloob merged commit 563e4fb into home-assistant:dev Apr 5, 2019
@ghost ghost removed the in progress label Apr 5, 2019
unibeck pushed a commit to unibeck/home-assistant that referenced this pull request Apr 7, 2019
@emontnemery emontnemery deleted the mqtt_deprecate_embedded branch April 28, 2019 09:27
@emontnemery emontnemery mentioned this pull request Jun 23, 2020
20 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants