Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate check-config to use get_integration #23026

Merged
merged 2 commits into from Apr 12, 2019
Merged

Migrate check-config to use get_integration #23026

merged 2 commits into from Apr 12, 2019

Conversation

balloob
Copy link
Member

@balloob balloob commented Apr 11, 2019

Description:

Converts the check config script to use async_get_integration.

Related issue (if applicable): fixes #23008

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.

If the code does not interact with devices:

  • Tests have been added to verify that the new code works.

@balloob balloob requested a review from kellerza as a code owner April 11, 2019 23:55
@balloob balloob force-pushed the check-config-get-integration branch from b5c71c8 to d676a4c Compare April 11, 2019 23:55
@homeassistant homeassistant added cla-signed core small-pr PRs with less than 30 lines. labels Apr 11, 2019
@ghost ghost assigned balloob Apr 11, 2019
@ghost ghost added the in progress label Apr 11, 2019
@codecov
Copy link

codecov bot commented Apr 12, 2019

Codecov Report

Merging #23026 into dev will decrease coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev   #23026      +/-   ##
==========================================
- Coverage   93.95%   93.95%   -0.01%     
==========================================
  Files         449      449              
  Lines       36751    36751              
==========================================
- Hits        34529    34528       -1     
- Misses       2222     2223       +1
Impacted Files Coverage Δ
...ssistant/components/islamic_prayer_times/sensor.py 94.73% <0%> (-1.06%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7e39e14...c35201c. Read the comment docs.

1 similar comment
@codecov
Copy link

codecov bot commented Apr 12, 2019 •
edited

Codecov Report

Merging #23026 into dev will decrease coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev   #23026      +/-   ##
==========================================
- Coverage   93.95%   93.95%   -0.01%     
==========================================
  Files         449      449              
  Lines       36751    36751              
==========================================
- Hits        34529    34528       -1     
- Misses       2222     2223       +1
Impacted Files Coverage Δ
...ssistant/components/islamic_prayer_times/sensor.py 94.73% <0%> (-1.06%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7e39e14...c35201c. Read the comment docs.

kellerza
kellerza approved these changes Apr 12, 2019
View reviewed changes
homeassistant/scripts/check_config.py
if platform is None:
try:
platform = p_integration.get_platform(domain)
except ImportError:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don’t seem to be unit testing for these ImportError blocks. Guess this should be a valid integration, with unimplemented platform.

add_error is already tested in a couple of places, so should be ok

@balloob balloob merged commit f269135 into dev Apr 12, 2019
@ghost ghost removed the in progress label Apr 12, 2019
@delete-merged-branch delete-merged-branch bot deleted the check-config-get-integration branch April 12, 2019 17:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kellerza kellerza kellerza approved these changes

Assignees

@balloob balloob

Labels
cla-signed core small-pr PRs with less than 30 lines.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Convert check_config script to use get_integration
3 participants
@balloob @kellerza @homeassistant