New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RFC: Upgrade philips_js component version and support channels and sources #23061
Conversation
A philips tv will never run on localhost
This allow us to delay update of state when we perform and action.
Codecov Report
@@ Coverage Diff @@
## dev #23061 +/- ##
==========================================
+ Coverage 93.93% 93.94% +<.01%
==========================================
Files 451 451
Lines 36759 36759
==========================================
+ Hits 34531 34532 +1
+ Misses 2228 2227 -1
Continue to review full report at Codecov.
|
My philips TV (api V1) doesn't update the status when it goes off (it continues to show the last source). I'm getting "Update for media_player.philips_tv fails" haphilipsjs.ConnectionFailure: HTTPConnectionPool(host='192.168.1.13', port=1925): Max retries exceeded with url: /1/channels/current (Caused by NewConnectionError('<urllib3.connection.HTTPConnection object at 0x6e02c6d0>: Failed to establish a new connection: [Errno 111] Connection refused')) It worked fine in home assistant 0.92 with ha-philipsjs 0.0.4 |
Please open a new issue, with a log and debug logging turned on. |
Description:
Related issue (if applicable): fixes #20740
Example entry for
configuration.yaml
(if applicable):Checklist:
tox
. Your PR cannot be merged unless tests passIf user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
[ ] New dependencies have been added torequirements
in the manifest (example).[ ] New dependencies are only imported inside functions that use them (example).requirements_all.txt
by runningscript/gen_requirements_all.py
.[ ] New files were added to.coveragerc
.If the code does not interact with devices: