Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RFC: Upgrade philips_js component version and support channels and sources #23061

Merged
merged 12 commits into from Apr 22, 2019

Conversation

elupus
Copy link
Contributor

@elupus elupus commented Apr 13, 2019

Description:

  • Upgrade philips_js to new source component which has restored support for v1 api
  • Combine sources/channels so user can select channels and sources
  • Manually schedule updates so actions take effect directly

Related issue (if applicable): fixes #20740

Example entry for configuration.yaml (if applicable):

  - platform: philips_js
    host: 192.168.16.21
    api_version: 1
    turn_on_action:
      service: 'switch.broadlink_send_packet_192_168_16_22'
      data:
        packet: 'JgAaAB0dOh0dHR0dHR0dHR0dHR0dOh0dOh0dAAuEDQUAAAAAAAAAAAAAAAA='

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly (example).
  • [ ] New dependencies have been added to requirements in the manifest (example).
  • [ ] New dependencies are only imported inside functions that use them (example).
  • New or updated dependencies have been added to requirements_all.txt by running script/gen_requirements_all.py.
  • [ ] New files were added to .coveragerc.

If the code does not interact with devices:

  • Tests have been added to verify that the new code works.

@codecov
Copy link

codecov bot commented Apr 21, 2019

Codecov Report

Merging #23061 into dev will increase coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev   #23061      +/-   ##
==========================================
+ Coverage   93.93%   93.94%   +<.01%     
==========================================
  Files         451      451              
  Lines       36759    36759              
==========================================
+ Hits        34531    34532       +1     
+ Misses       2228     2227       -1
Impacted Files Coverage Δ
homeassistant/components/uk_transport/sensor.py 94.16% <0%> (+0.72%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 73a473a...409bd4f. Read the comment docs.

@balloob balloob merged commit e85af58 into home-assistant:dev Apr 22, 2019
@elupus elupus deleted the philips_js_clean branch May 2, 2019 11:04
@balloob balloob mentioned this pull request May 14, 2019
@harisma-git
Copy link

harisma-git commented Jun 9, 2019

My philips TV (api V1) doesn't update the status when it goes off (it continues to show the last source). I'm getting "Update for media_player.philips_tv fails"

haphilipsjs.ConnectionFailure: HTTPConnectionPool(host='192.168.1.13', port=1925): Max retries exceeded with url: /1/channels/current (Caused by NewConnectionError('<urllib3.connection.HTTPConnection object at 0x6e02c6d0>: Failed to establish a new connection: [Errno 111] Connection refused'))

It worked fine in home assistant 0.92 with ha-philipsjs 0.0.4

@elupus
Copy link
Contributor Author

elupus commented Jun 9, 2019

Please open a new issue, with a log and debug logging turned on.

@home-assistant home-assistant locked as resolved and limited conversation to collaborators Jun 10, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Source and source list not available for Philips TV (philips_js)
4 participants