Pass configured host string instead of always forcing an ip-address #23164

itn3rd77 · 2019-04-17T12:25:11Z

Pass the configured host (https://www.home-assistant.io/components/homematic/#host) instead of always forcing an ip-address. This is required to get SSL certificate validation working.

Breaking Change:

Not that I'm aware of

Description:

The current implementation in the component at lines homeassistant/components/homematic/init.py#L265 and homeassistant/components/homematic/init.py#L281 always forces an ip-address passed to pyhomematic. This made it practically impossible to get SSL certificate validation working. With the proposed changes the configured value for host is passed to pyhomematic. If a user wants to pass an ip-address he is free to do.

Talking to @danielperna84 the maintainer of pyhomematic he wasn't even aware of this. I would have renamed the key 'id' to 'host' but @danielperna84 said it's not worth the effort as pyhomematic has to be adpted than as well.

This is my first pull request for Home Assistant so please bear with me if I have forgotten something.

Checklist:

The code change is tested and works locally.
Local tests pass with tox. Your PR cannot be merged unless tests pass
There is no commented out code in this PR.

If user exposed functionality or configuration variables are added/changed:

Documentation added/updated in home-assistant.io

If the code communicates with devices, web services, or third-party tools:

The manifest file has all fields filled out correctly (example).
New dependencies have been added to requirements in the manifest (example).
New dependencies are only imported inside functions that use them (example).
New or updated dependencies have been added to requirements_all.txt by running script/gen_requirements_all.py.
New files were added to .coveragerc.

If the code does not interact with devices:

Tests have been added to verify that the new code works.

Pass the configured host (https://www.home-assistant.io/components/homematic/#host) instead of always forcing an ip-address. This is required to get SSL certificate validation working.

github-actions · 2019-04-17T12:26:00Z

Hey there @pvizeli, @danielperna84, mind taking a look at this pull request as its been labeled with a integration (homematic) you are listed as a codeowner for? Thanks!

pvizeli · 2019-04-17T12:29:47Z

homeassistant/components/homematic/__init__.py

@@ -262,7 +262,7 @@ def setup(hass, config):
    # Create hosts-dictionary for pyhomematic
    for rname, rconfig in conf[CONF_INTERFACES].items():
        remotes[rname] = {
-            'ip': socket.gethostbyname(rconfig.get(CONF_HOST)),
+            'ip': rconfig.get(CONF_HOST),


That is only for xmlrpc server they we run. You are sure that you not only mean the settings from hosts part?

Sorry I don't get what you mean. I'm using Home Assistant for three days now and not very familiar with the whole stuff. Without the changes I got the following exception:

2019-04-16 07:58:42 DEBUG (SyncWorker_19) [pyhomematic.connection] HMConnection: Creating server object 2019-04-16 07:58:42 DEBUG (SyncWorker_19) [pyhomematic._hm] ServerThread.__init__ 2019-04-16 07:58:42 DEBUG (SyncWorker_19) [pyhomematic._hm] __init__: Creating proxies 2019-04-16 07:58:42 INFO (SyncWorker_19) [pyhomematic._hm] Creating proxy rf. Connecting to 192.168.100.74:42001 2019-04-16 07:58:42 DEBUG (SyncWorker_19) [pyhomematic._hm] LockingServerProxy.__init__: Getting local ip 2019-04-16 07:58:42 DEBUG (SyncWorker_19) [pyhomematic._hm] LockingServerProxy.__init__: Got local ip 192.168.100.2 2019-04-16 07:58:42 INFO (SyncWorker_19) [pyhomematic._hm] Creating proxy ip. Connecting to 192.168.100.74:42010 2019-04-16 07:58:42 DEBUG (SyncWorker_19) [pyhomematic._hm] LockingServerProxy.__init__: Getting local ip 2019-04-16 07:58:42 DEBUG (SyncWorker_19) [pyhomematic._hm] LockingServerProxy.__init__: Got local ip 192.168.100.2 2019-04-16 07:58:42 INFO (SyncWorker_19) [pyhomematic._hm] Creating proxy raspberrymatic. Connecting to 192.168.100.74:2001 2019-04-16 07:58:42 DEBUG (SyncWorker_19) [pyhomematic._hm] LockingServerProxy.__init__: Getting local ip 2019-04-16 07:58:42 DEBUG (SyncWorker_19) [pyhomematic._hm] LockingServerProxy.__init__: Got local ip 192.168.100.2 2019-04-16 07:58:42 DEBUG (SyncWorker_19) [pyhomematic._hm] RPCFunctions.__init__ 2019-04-16 07:58:42 DEBUG (SyncWorker_19) [pyhomematic._hm] RPCFunctions.__init__: iterating proxy = homeassistant-rf 2019-04-16 07:58:42 DEBUG (SyncWorker_19) [pyhomematic._hm] RPCFunctions.__init__: iterating proxy = homeassistant-ip 2019-04-16 07:58:42 DEBUG (SyncWorker_19) [pyhomematic._hm] RPCFunctions.__init__: iterating proxy = homeassistant-raspberrymatic 2019-04-16 07:58:42 DEBUG (SyncWorker_19) [pyhomematic._hm] ServerThread.__init__: Setting up server 2019-04-16 07:58:42 DEBUG (SyncWorker_19) [pyhomematic._hm] ServerThread.__init__: Registering RPC functions 2019-04-16 07:58:42 INFO (Thread-3) [pyhomematic._hm] Starting server at http://0.0.0.0:47051 2019-04-16 07:58:42 DEBUG (SyncWorker_19) [pyhomematic._hm] ServerThread.proxyInit: init('http://192.168.100.2:47051', 'homeassistant-rf') 2019-04-16 07:58:42 DEBUG (SyncWorker_19) [pyhomematic._hm] proxyInit: Exception: [SSL: CERTIFICATE_VERIFY_FAILED] certificate verify failed: IP address mismatch, certificate is not valid for '192.168.100.74'. (_ssl.c:1056) 2019-04-16 07:58:42 WARNING (SyncWorker_19) [pyhomematic._hm] Failed to initialize proxy 2019-04-16 07:58:42 DEBUG (SyncWorker_19) [pyhomematic._hm] ServerThread.proxyInit: init('http://192.168.100.2:47051', 'homeassistant-ip') 2019-04-16 07:58:42 DEBUG (SyncWorker_19) [pyhomematic._hm] proxyInit: Exception: [SSL: CERTIFICATE_VERIFY_FAILED] certificate verify failed: IP address mismatch, certificate is not valid for '192.168.100.74'. (_ssl.c:1056) 2019-04-16 07:58:42 WARNING (SyncWorker_19) [pyhomematic._hm] Failed to initialize proxy

All those created proxies are connecting to an IP address (as previously forced). And as far as I understand the settings used beneath the line pyhomematic/_hm.py#L521 come from remotes settings.

But maybe I am completely lost at the moment :-/

@pvizeli
socket.gethostbyname turns myhost.local into 192.168.1.123. So even with the hostname correctly set in configuration.yaml, the component initializes pyhomematic with the IP addresses. pyhomematic has gained SSL support since the release of the CCU3 (and recent RaspberryMatic releases). Verification of course fails because the IP address never matches the hostname of the certificate.

codecov · 2019-04-17T14:28:26Z

Codecov Report

Merging #23164 into dev will not change coverage.
The diff coverage is n/a.

@@          Coverage Diff           @@
##             dev   #23164   +/-   ##
======================================
  Coverage   94.2%    94.2%           
======================================
  Files        453      453           
  Lines      36913    36913           
======================================
  Hits       34773    34773           
  Misses      2140     2140

Impacted Files	Coverage Δ
...ssistant/components/islamic_prayer_times/sensor.py	`94.68% <0%> (-1.07%)`	⬇️
homeassistant/components/uk_transport/sensor.py	`94.16% <0%> (+0.72%)`	⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 37ca9ca...605b797. Read the comment docs.

pvizeli

For me is fine. @danielperna84 ?

danielperna84 · 2019-04-17T19:24:08Z

@pvizeli
Just commented on your comment. ^^
Yes, I'm fine with it. 👍

itn3rd77 · 2019-05-14T04:05:11Z

Could this PR be added to the 0.93 milestone?

Pass host string instead of forcing an ip-address

65667c0

Pass the configured host (https://www.home-assistant.io/components/homematic/#host) instead of always forcing an ip-address. This is required to get SSL certificate validation working.

itn3rd77 requested review from danielperna84 and pvizeli as code owners April 17, 2019 12:25

homeassistant added cla-signed integration: homematic small-pr PRs with less than 30 lines. labels Apr 17, 2019

OverloadUT added the in progress label Apr 17, 2019

github-actions bot assigned danielperna84 and pvizeli Apr 17, 2019

pvizeli reviewed Apr 17, 2019

View reviewed changes

Remove unused 'socket' import

605b797

pvizeli approved these changes Apr 17, 2019

View reviewed changes

pvizeli merged commit 0afa016 into home-assistant:dev Apr 17, 2019

pvizeli removed the in progress label Apr 17, 2019

itn3rd77 deleted the itn3rd77-pass-host branch April 18, 2019 03:56

balloob mentioned this pull request May 14, 2019

0.93.0 #23864

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Pass configured host string instead of always forcing an ip-address #23164

Pass configured host string instead of always forcing an ip-address #23164

itn3rd77 commented Apr 17, 2019

github-actions bot commented Apr 17, 2019

pvizeli Apr 17, 2019

itn3rd77 Apr 17, 2019

danielperna84 Apr 17, 2019

codecov bot commented Apr 17, 2019 •

edited

pvizeli left a comment

danielperna84 commented Apr 17, 2019

itn3rd77 commented May 14, 2019

Pass configured host string instead of always forcing an ip-address #23164

Pass configured host string instead of always forcing an ip-address #23164

Conversation

itn3rd77 commented Apr 17, 2019

Breaking Change:

Description:

Checklist:

github-actions bot commented Apr 17, 2019

pvizeli Apr 17, 2019

Choose a reason for hiding this comment

itn3rd77 Apr 17, 2019

Choose a reason for hiding this comment

danielperna84 Apr 17, 2019

Choose a reason for hiding this comment

codecov bot commented Apr 17, 2019 • edited

Codecov Report

pvizeli left a comment

Choose a reason for hiding this comment

danielperna84 commented Apr 17, 2019

itn3rd77 commented May 14, 2019

codecov bot commented Apr 17, 2019 •

edited