Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.Sign up
Pass configured host string instead of always forcing an ip-address #23164
Pass the configured host (https://www.home-assistant.io/components/homematic/#host) instead of always forcing an ip-address. This is required to get SSL certificate validation working.
Not that I'm aware of
The current implementation in the component at lines homeassistant/components/homematic/init.py#L265 and homeassistant/components/homematic/init.py#L281 always forces an ip-address passed to pyhomematic. This made it practically impossible to get SSL certificate validation working. With the proposed changes the configured value for host is passed to pyhomematic. If a user wants to pass an ip-address he is free to do.
Talking to @danielperna84 the maintainer of pyhomematic he wasn't even aware of this. I would have renamed the key
This is my first pull request for Home Assistant so please bear with me if I have forgotten something.
If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
If the code does not interact with devices:
referenced this pull request
Apr 17, 2019
@@ Coverage Diff @@ ## dev #23164 +/- ## ====================================== Coverage 94.2% 94.2% ====================================== Files 453 453 Lines 36913 36913 ====================================== Hits 34773 34773 Misses 2140 2140