Create services.yaml for input_datetime #23303
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
balloob
reviewed
Apr 22, 2019
| set_datetime: | ||
| description: This can be used to dynamically set the date and/or time. | ||
| fields: | ||
| entity_id: {description: Entity id of the input datetime to set the new value., |
There was a problem hiding this comment.
Why are you using such weird YAML constructs. Sure it's valid, but does not look nice?
There was a problem hiding this comment.
I just copied from others, for example https://github.com/home-assistant/home-assistant/blob/dev/homeassistant/components/input_select/services.yaml.
Not correct?
There was a problem hiding this comment.
Correct, but could be better 😉
I'll see if I can write a script to fix them all.
balloob
approved these changes
Apr 22, 2019
balloob
pushed a commit
that referenced
this pull request
Apr 23, 2019
* Create services.yaml for input_datetime * HA error while parsing a flow mapping
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Breaking Change:
Description:
Related issue (if applicable): fixes #
Pull request in home-assistant.io with documentation (if applicable): home-assistant/home-assistant.io#<home-assistant.io PR number goes here>
Example entry for
configuration.yaml(if applicable):Checklist:
tox. Your PR cannot be merged unless tests passIf user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
requirementsin the manifest (example).requirements_all.txtby runningscript/gen_requirements_all.py..coveragerc.If the code does not interact with devices: