Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New cover platform for ADS integration #23377

Merged
merged 5 commits into from May 8, 2019
Merged

New cover platform for ADS integration #23377

merged 5 commits into from May 8, 2019

Conversation

carstenschroeder
Copy link
Contributor

@carstenschroeder carstenschroeder commented Apr 25, 2019 •
edited

Description:

Adds new cover platform for ADS integration

Pull request in home-assistant.io with documentation (if applicable): home-assistant/home-assistant.io#9296

Example entry for configuration.yaml (if applicable):

cover:
  - platform: ads
    name: Curtain master bed room
    adsvar_open: covers.master_bed_room_open
    adsvar_close: covers.master_bed_room_close
    adsvar_stop: covers.master_bed_room_stop
    device_class: curtain

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly (example).
  • New dependencies have been added to requirements in the manifest (example).
  • New dependencies are only imported inside functions that use them (example).
  • New or updated dependencies have been added to requirements_all.txt by running script/gen_requirements_all.py.
  • New files were added to .coveragerc.

@carstenschroeder carstenschroeder mentioned this pull request Apr 25, 2019
Merged
2 tasks
MartinHjelmare
MartinHjelmare requested changes May 5, 2019
View reviewed changes
Copy link
Member

@MartinHjelmare MartinHjelmare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Some comments.

homeassistant/components/ads/cover.py Outdated Show resolved Hide resolved
homeassistant/components/ads/cover.py Outdated Show resolved Hide resolved
homeassistant/components/ads/cover.py Outdated Show resolved Hide resolved
homeassistant/components/ads/cover.py Outdated Show resolved Hide resolved
homeassistant/components/ads/cover.py Outdated Show resolved Hide resolved
@carstenschroeder
Copy link
Contributor Author

@MartinHjelmare done

MartinHjelmare
MartinHjelmare approved these changes May 5, 2019
View reviewed changes
Copy link
Member

@MartinHjelmare MartinHjelmare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great!

@MartinHjelmare
Copy link
Member

Can be merged when build passes.

@MartinHjelmare MartinHjelmare merged commit 8822f01 into home-assistant:dev May 8, 2019
@balloob balloob mentioned this pull request May 14, 2019
Merged
alandtse pushed a commit to alandtse/home-assistant that referenced this pull request Oct 12, 2019
@carstenschroeder @alandtse
New cover platform for ADS integration (home-assistant#23377)
5bf7bb8 
* new cover platform

* improve logging II

* remove dependencies

* fix comment

* fix review findings
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MartinHjelmare MartinHjelmare MartinHjelmare approved these changes

Assignees
No one assigned
Labels
cla-signed integration: ads new-platform
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@carstenschroeder @MartinHjelmare @homeassistant