Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add core APIs to migrate device identifiers and entity unique_id #23481

Merged
merged 4 commits into from Apr 30, 2019

Conversation

Projects
None yet
3 participants
@andrewsayre
Copy link
Member

commented Apr 27, 2019

Description:

Add core APIs to migrate device identifiers to a new set and entity unique_id to a new value. This lays the foundation which will be utilized by HEOS as described in this alternate approach #23295

Related architectural issue: fixes home-assistant/architecture#215

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.

If the code does not interact with devices:

  • Tests have been added to verify that the new code works.

@andrewsayre andrewsayre requested a review from home-assistant/core as a code owner Apr 27, 2019

andrewsayre added some commits Apr 27, 2019

@andrewsayre andrewsayre force-pushed the id_migration branch from afcb07c to d3528b5 Apr 28, 2019

@andrewsayre andrewsayre requested a review from MartinHjelmare Apr 28, 2019

Show resolved Hide resolved homeassistant/helpers/device_registry.py Outdated
Show resolved Hide resolved homeassistant/helpers/entity_registry.py Outdated

@balloob balloob merged commit cfaaae6 into dev Apr 30, 2019

13 checks passed

build Workflow: build
Details
ci/circleci: pre-install-all-requirements Your tests passed on CircleCI!
Details
ci/circleci: pre-test 3.5.5 Your tests passed on CircleCI!
Details
ci/circleci: pre-test 3.6 Your tests passed on CircleCI!
Details
ci/circleci: pre-test 3.7 Your tests passed on CircleCI!
Details
ci/circleci: pylint Your tests passed on CircleCI!
Details
ci/circleci: static-check Your tests passed on CircleCI!
Details
ci/circleci: test 3.5.5 Your tests passed on CircleCI!
Details
ci/circleci: test 3.6 Your tests passed on CircleCI!
Details
ci/circleci: test 3.7 Your tests passed on CircleCI!
Details
cla-bot Everyone involved has signed the CLA
codecov/patch 100% of diff hit (target 93.8%)
Details
codecov/project 93.8% (target 90%)
Details

@delete-merged-branch delete-merged-branch bot deleted the id_migration branch Apr 30, 2019

@andrewsayre andrewsayre referenced this pull request May 3, 2019

Merged

Update IDs after firmware upgrade in HEOS #23641

4 of 4 tasks complete

@balloob balloob referenced this pull request May 14, 2019

Merged

0.93.0 #23864

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.