Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean up ZHA discovery logic #23563

Merged
merged 3 commits into from Apr 30, 2019
Merged

Clean up ZHA discovery logic #23563

merged 3 commits into from Apr 30, 2019

Conversation

dmulcahey
Copy link
Contributor

Description:

Clean up in discovery. Use domain constants and streamline duplicated logic.

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.

@homeassistant homeassistant added cla-signed small-pr PRs with less than 30 lines. labels Apr 30, 2019
@ghost ghost assigned Adminiuga and dmulcahey Apr 30, 2019
@ghost
Copy link

ghost commented Apr 30, 2019

Hey there @Adminiuga, mind taking a look at this pull request as its been labeled with a integration (zha) you are listed as a codeowner for? Thanks!

This is a automatic comment generated by codeowners-mention to help ensure issues and pull requests are seen by the right people.

Adminiuga
Adminiuga approved these changes Apr 30, 2019
View reviewed changes
Copy link
Contributor

@Adminiuga Adminiuga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can be merged when the passes the build.

@dmulcahey dmulcahey merged commit d71424f into home-assistant:dev Apr 30, 2019
@dmulcahey dmulcahey deleted the dm/zha-misc-cleanup branch May 8, 2019 10:56
@balloob balloob mentioned this pull request May 14, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Adminiuga Adminiuga Adminiuga approved these changes

Assignees

@dmulcahey dmulcahey

@Adminiuga Adminiuga

Labels
cla-signed integration: zha small-pr PRs with less than 30 lines.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@dmulcahey @Adminiuga @homeassistant