Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle icons for None sensor values gracefully of huawei_lte #23649

Merged
merged 1 commit into from May 6, 2019
Merged

Handle icons for None sensor values gracefully of huawei_lte #23649

merged 1 commit into from May 6, 2019

Conversation

scop
Copy link
Member

@scop scop commented May 3, 2019

Description:

Avoid errors when trying to render icons for None values.

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly (example).
  • New dependencies have been added to requirements in the manifest (example).
  • New or updated dependencies have been added to requirements_all.txt by running script/gen_requirements_all.py.
  • New files were added to .coveragerc.

If the code does not interact with devices:

  • Tests have been added to verify that the new code works.

@ghost ghost assigned scop May 3, 2019
@fabaff fabaff changed the title huawei_lte: handle icons for None sensor values gracefully Handle icons for None sensor values gracefully of huawei_lte May 4, 2019
@awarecan awarecan merged commit b9a7203 into home-assistant:dev May 6, 2019
@scop scop deleted the huawei-lte-none-sensor branch May 8, 2019 14:59
@balloob balloob mentioned this pull request May 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants