Update the name of Zestimate sensors #23770
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
homeassistant
added
integration: zestimate
cla-signed
small-pr
|
Wouldn't this be a breaking change? Entities would get new ids |
It didn't break mine when I was testing. It just renamed them. What determines what ID's get assigned? |
|
If the entity id change its a breaking change. If entities has unique id it would keep the same if regardless of name |
yes it is a breaking change. I updated the pull pull request to indicate it. thx |
andrewsayre
previously requested changes
May 9, 2019
|
It's not a breaking change if entities have a unique ID. |
|
@balloob they don’t have a unique id, there’s a previous PR to add it. |
Changed name property to return Zestimate and the property address. This will make it easier distinguish multiple Zestimate sensor entities in the UI. Also removed MIN_TIME_BETWEEN_UPDATES in favor of SCAN_INTERVAL per suggestion from amelchio#9580 on Discord
Changed name property to return Zestimate and the property address. This will make it easier distinguish multiple Zestimate sensor entities in the UI.
and the property address. This will make it easier distinguish multiple Zestimate sensor entities in the UI.
balloob
reviewed
May 13, 2019
fabaff
changed the title
fabaff
approved these changes
May 24, 2019
Merged
alandtse
pushed a commit
to alandtse/home-assistant
that referenced
this pull request
Oct 12, 2019
* Zestimate: fix for issue home-assistant#23757 Changed name property to return Zestimate and the property address. This will make it easier distinguish multiple Zestimate sensor entities in the UI. Also removed MIN_TIME_BETWEEN_UPDATES in favor of SCAN_INTERVAL per suggestion from amelchio#9580 on Discord * Zestimate fix for issue home-assistant#23757 Changed name property to return Zestimate and the property address. This will make it easier distinguish multiple Zestimate sensor entities in the UI. * Changed name property to return Zestimate and the property address. This will make it easier distinguish multiple Zestimate sensor entities in the UI. * moved code fix to the correct function * removed code change from unique_id function
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Breaking Change:
This is a breaking change as it will change entity_id of Zestimate sensors. If you have automations relying on your Zestimate sensor(s) you may need to revisit them to fix the ID's to the new ones. Also, you may need to update your Zestimate sensor(s) in your Lovelace UI.
Description:
Changed name property to return Zestimate
and the property address. This will make it easier
to distinguish multiple Zestimate sensor entities
in the UI.
Also removed MIN_TIME_BETWEEN_UPDATES in
favor of SCAN_INTERVAL per suggestion from
amelchio#9580 on Discord
Related issue (if applicable): fixes #
fixes #23757
Pull request with documentation for home-assistant.io (if applicable): home-assistant/home-assistant.io#<home-assistant.io PR number goes here>
Example entry for
configuration.yaml(if applicable):Checklist:
tox. Your PR cannot be merged unless tests passIf user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
python3 -m script.hassfest.requirements_all.txtby runningpython3 -m script.gen_requirements_all..coveragerc.If the code does not interact with devices: