Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for non existing Daikin zones #23792

Merged
merged 1 commit into from May 17, 2019

Conversation

fredrike
Copy link
Contributor

@fredrike fredrike commented May 10, 2019

Description:

This fixes non existing Daikin zones so they will not show up as switches.

Related issue (if applicable): fixes #

Pull request in home-assistant.io with documentation (if applicable): home-assistant/home-assistant.io#<home-assistant.io PR number goes here>

Example entry for configuration.yaml (if applicable):

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly (example).
  • New dependencies have been added to requirements in the manifest (example).
  • New dependencies are only imported inside functions that use them (example).
  • New or updated dependencies have been added to requirements_all.txt by running script/gen_requirements_all.py.
  • New files were added to .coveragerc.

If the code does not interact with devices:

  • Tests have been added to verify that the new code works.

@ghost ghost assigned fredrike May 10, 2019
@ghost
Copy link

ghost commented May 10, 2019

Hey there @rofrantz, mind taking a look at this pull request as its been labeled with a integration (daikin) you are listed as a codeowner for? Thanks!

This is a automatic comment generated by codeowners-mention to help ensure issues and pull requests are seen by the right people.

@fredrike
Copy link
Contributor Author

Bug fix for an bug introduced in #23792

@MartinHjelmare
Copy link
Member

#23792 is this PR. Is there an issue we should close?

@fredrike
Copy link
Contributor Author

#23792 is this PR. Is there an issue we should close?

I ment #23113, that PR didn't really fix the problem, this does and have been verified by the users with AirBase units.

@MartinHjelmare MartinHjelmare merged commit 1b4fc2a into home-assistant:dev May 17, 2019
@fredrike fredrike deleted the daikin-zones branch May 17, 2019 07:35
@balloob balloob mentioned this pull request Jun 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants