Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace pyunifi with aiounifi in UniFi device tracker #24149

Merged
merged 5 commits into from Jun 2, 2019

Conversation

Kane610
Copy link
Member

@Kane610 Kane610 commented May 27, 2019

Breaking Change:

Description:

First step towards making UniFi device tracker a part of the UniFi config entry.

Related issue (if applicable): should solve #23490

Pull request with documentation for home-assistant.io (if applicable): home-assistant/home-assistant.io#<home-assistant.io PR number goes here>

Example entry for configuration.yaml (if applicable):

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly. Update and include derived files by running python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

If the code does not interact with devices:

  • Tests have been added to verify that the new code works.

@ghost
Copy link

ghost commented May 27, 2019

Hey there @Kane610, mind taking a look at this pull request as its been labeled with a integration (unifi) you are listed as a codeowner for? Thanks!

This is a automatic comment generated by codeowners-mention to help ensure issues and pull requests are seen by the right people.

@Kane610 Kane610 force-pushed the unifi-async-device-tracker branch 2 times, most recently from 82574c3 to ce5eaf2 Compare May 30, 2019 14:24
@Kane610 Kane610 marked this pull request as ready for review June 1, 2019 21:47
@Kane610 Kane610 merged commit 4d4fd19 into home-assistant:dev Jun 2, 2019
@Kane610 Kane610 deleted the unifi-async-device-tracker branch June 2, 2019 16:24
Kane610 added a commit to Kane610/home-assistant that referenced this pull request Jun 7, 2019
…#24149)

* Replace pyunifi with aiounifi

* Fix tests

* Add sslcontext

* Fix tests

* Fix import order
Kane610 added a commit to Kane610/home-assistant that referenced this pull request Jun 9, 2019
…#24149)

* Replace pyunifi with aiounifi

* Fix tests

* Add sslcontext

* Fix tests

* Fix import order
Kane610 added a commit to Kane610/home-assistant that referenced this pull request Jun 11, 2019
…#24149)

* Replace pyunifi with aiounifi

* Fix tests

* Add sslcontext

* Fix tests

* Fix import order
Kane610 added a commit to Kane610/home-assistant that referenced this pull request Jun 15, 2019
…#24149)

* Replace pyunifi with aiounifi

* Fix tests

* Add sslcontext

* Fix tests

* Fix import order
Kane610 added a commit to Kane610/home-assistant that referenced this pull request Jun 15, 2019
…#24149)

* Replace pyunifi with aiounifi

* Fix tests

* Add sslcontext

* Fix tests

* Fix import order
Kane610 added a commit to Kane610/home-assistant that referenced this pull request Jun 15, 2019
…#24149)

* Replace pyunifi with aiounifi

* Fix tests

* Add sslcontext

* Fix tests

* Fix import order
@balloob balloob mentioned this pull request Jun 26, 2019
@patrik3k
Copy link
Contributor

patrik3k commented Jun 27, 2019

Hi, maybe this is the wrong way to report this but after 0.95 i get the below error.
I have the following config in configuration.yaml

device_tracker:
  - platform: unifi
    host: localhost
    username: homeassistant
    password: xxxxx
    port: 8443
    verify_ssl: false
2019-06-27 03:53:48 ERROR (MainThread) [homeassistant.components.device_tracker] Error setting up platform legacy
Traceback (most recent call last):
  File "/Library/Frameworks/Python.framework/Versions/3.6/lib/python3.6/site-packages/homeassistant/components/device_tracker/setup.py", line 66, in async_setup_legacy
    hass, {DOMAIN: self.config})
  File "/Library/Frameworks/Python.framework/Versions/3.6/lib/python3.6/site-packages/homeassistant/components/unifi/device_tracker.py", line 79, in async_get_scanner
    hass, host, username, password, port, site_id, verify_ssl)
  File "/Library/Frameworks/Python.framework/Versions/3.6/lib/python3.6/site-packages/homeassistant/components/unifi/controller.py", line 145, in get_controller
    websession=session, sslcontext=sslcontext
TypeError: __init__() got an unexpected keyword argument 'sslcontext'

@Kane610
Copy link
Member Author

Kane610 commented Jun 27, 2019

@patrik3k sounds to me like your dependency didn't upgrade properly. You should create new issues and not use PRs to report issues

Kane610 added a commit to Kane610/home-assistant that referenced this pull request Jul 1, 2019
…#24149)

* Replace pyunifi with aiounifi

* Fix tests

* Add sslcontext

* Fix tests

* Fix import order
@aheath70
Copy link

aheath70 commented Jul 3, 2019

@patrik3k did you already create a new issue for this? I am having exactly the same issue.

Kane610 added a commit to Kane610/home-assistant that referenced this pull request Jul 4, 2019
…#24149)

* Replace pyunifi with aiounifi

* Fix tests

* Add sslcontext

* Fix tests

* Fix import order
@stephanerosi
Copy link
Contributor

@aheath70 @patrik3k Same issue, i did "pip uninstall pyunifi" in my environment

@home-assistant home-assistant locked as resolved and limited conversation to collaborators Jul 7, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants