Fix ESPHome discovered when already exists #24187
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
balloob
approved these changes
May 30, 2019
balloob
pushed a commit
that referenced
this pull request
May 30, 2019
* Fix ESPHome discovered when already exists * Update .coveragerc
Merged
This was referenced Jun 24, 2019
alandtse
pushed a commit
to alandtse/home-assistant
that referenced
this pull request
Oct 12, 2019
* Fix ESPHome discovered when already exists * Update .coveragerc
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Fix ESPHome devices marked discovered even when they already exist.
In order to accomplish that, the esphome integration had to be restructured a bit - the RuntimeEntryData class had to be moved out of init.py so that config_flow.py can access it.
Also contains a small fix for the ESPHome startup behavior: ESPHome will no longer delay HA startup by ~20s if a device cannot be contacted.
Checklist:
tox. Your PR cannot be merged unless tests pass