Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deCONZ migrate to SSDP discovery #24252

Merged
merged 8 commits into from Jun 3, 2019

Conversation

@Kane610
Copy link
Contributor

commented Jun 2, 2019

Add new discovery info manufacturer URL to be able to separate Hue and deCONZ bridges

Breaking Change:

Description:

Use new SSDP discovery
Discern between Hue and deCONZ bridge on manufacturer URL.

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly. Update and include derived files by running python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

If the code does not interact with devices:

  • Tests have been added to verify that the new code works.
Migrate deCONZ to use new SSDP discovery
Add new discovery info manufacturer URL to be able to separate Hue and deCONZ bridges
@codeowners-notifier

This comment has been minimized.

Copy link

commented Jun 2, 2019

Hey there @balloob, mind taking a look at this pull request as its been labeled with a integration (hue) you are listed as a codeowner for? Thanks!

This is a automatic comment generated by codeowners-mention to help ensure issues and pull requests are seen by the right people.

@codeowners-notifier

This comment has been minimized.

Copy link

commented Jun 2, 2019

Hey there @Kane610, mind taking a look at this pull request as its been labeled with a integration (deconz) you are listed as a codeowner for? Thanks!

This is a automatic comment generated by codeowners-mention to help ensure issues and pull requests are seen by the right people.

@Kane610 Kane610 marked this pull request as ready for review Jun 2, 2019

@Kane610 Kane610 requested a review from balloob as a code owner Jun 2, 2019

Kane610 added some commits Jun 2, 2019

@Kane610

This comment has been minimized.

Copy link
Contributor Author

commented Jun 2, 2019

@balloob Ok to expand SSDP to add manufacturerURL?

@balloob

This comment has been minimized.

Copy link
Member

commented Jun 2, 2019

Doesn't Deconz have other discovery mechanics ?

@Kane610

This comment has been minimized.

Copy link
Contributor Author

commented Jun 2, 2019

@balloob yes, but if it changes host address (which is likely with docker) only the ssdp discovery will track that.

@balloob

This comment has been minimized.

Copy link
Member

commented Jun 2, 2019

Can't you do something like this:

  • Use discovery mechanism that's not Hue
  • Query the SSDP device description XML
  • Profit

Kane610 added some commits Jun 2, 2019

@balloob

balloob approved these changes Jun 3, 2019

@balloob balloob merged commit 449a7d3 into home-assistant:dev Jun 3, 2019

13 of 14 checks passed

codecov/patch 92.3% of diff hit (target 94.22%)
Details
build Workflow: build
Details
ci/circleci: pre-install-all-requirements Your tests passed on CircleCI!
Details
ci/circleci: pre-test 3.5.5 Your tests passed on CircleCI!
Details
ci/circleci: pre-test 3.6 Your tests passed on CircleCI!
Details
ci/circleci: pre-test 3.7 Your tests passed on CircleCI!
Details
ci/circleci: pylint Your tests passed on CircleCI!
Details
ci/circleci: static-check Your tests passed on CircleCI!
Details
ci/circleci: test 3.5.5 Your tests passed on CircleCI!
Details
ci/circleci: test 3.6 Your tests passed on CircleCI!
Details
ci/circleci: test 3.7 Your tests passed on CircleCI!
Details
cla-bot Everyone involved has signed the CLA
codecov/project 94.21% (target 90%)
Details
home-assistant Build #20190603.31 succeeded
Details

@Kane610 Kane610 deleted the Kane610:deconz-use-ssdp-discovery branch Jun 3, 2019

@Kane610

This comment has been minimized.

Copy link
Contributor Author

commented Jun 3, 2019

🎉

@balloob balloob added this to the 0.94.0 milestone Jun 3, 2019

balloob added a commit that referenced this pull request Jun 3, 2019

deCONZ migrate to SSDP discovery (#24252)
* Migrate deCONZ to use new SSDP discovery
Add new discovery info manufacturer URL to be able to separate Hue and deCONZ bridges

* Mark deCONZ as migrated in Discovery component

* Fix tests

* Fix Hue discovery ignore deCONZ bridge

* Less snake more badger

* Mushroom

* Fix indentation

* Config flow ignore manufacturer url that is not philips

@balloob balloob referenced this pull request Jun 4, 2019

Merged

0.94.0 #24305

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.