Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vlc telnet #24274

Closed
wants to merge 6 commits into from
Closed

Vlc telnet #24274

wants to merge 6 commits into from

Conversation

rodripf
Copy link
Contributor

@rodripf rodripf commented Jun 3, 2019

Description:

Trying to resolve this issue referenced in the vlc component doc I developed a component to control any instance of VLC running its built in telnet interface.

Alongside with this component, I've put together an add-on for the hassio platform to run a VLC instance locally.

Pull request with documentation for home-assistant.io (if applicable): home-assistant/home-assistant.io#9558

Example entry for configuration.yaml (if applicable):

# Example configuration.yaml entry
media_player:
  - platform: vlc-telnet
    name: speaker_1
    host: "192.168.1.56"
    port: 4321
    password: "secure_password"

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly. Update and include derived files by running python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

If the code does not interact with devices:

  • Tests have been added to verify that the new code works.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants