Add shuffle support for itunes component #24319
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @kvanhoorn, It seems you haven't yet signed a CLA. Please do so here. Once you do that we will be able to review and accept this pull request. Thanks! |
kvanhoorn
changed the title
andrewsayre
approved these changes
Jun 8, 2019
There was a problem hiding this comment.
Welcome and nice job!
Couple things to know:
- Communication with devices should be abstracted in a library hosted in Pypi. The
itunesintegration is older and predates this development guideline. We tend to be more restrictive on PRs that propagate the anti-pattern, but this case is fine. I'd suggest checking on Discord before doing any other major work though on legacy integrations that aren't current with the development standards. - Apple has announced they are killing off iTunes (splitting it into multiple apps). I don't know if the new API will be compatible with the iTunes API, so you may not want to put too much more work into this integration until we know more.
|
Hi @andrewsayre I know they will stop supporting iTunes. Luckily for me I'm using an older Mac Pro, which won't support the new apps. Next to that I'm need for it now, and I wanted to give back! Thanks for welcoming me. When I have more features I will create a PR :) |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Added support for shuffle in itunes component
Checklist:
tox. Your PR cannot be merged unless tests passIf user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
python3 -m script.hassfest.requirements_all.txtby runningpython3 -m script.gen_requirements_all..coveragerc.If the code does not interact with devices: