Remove conversation from default config #24515
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
homeassistant
added
cla-signed
core
integration: default_config
small-pr
|
I canceled pylint and Python 3.7 tests because Circle is swamped, there are no Python changes, and if 3.5 passes, 3.7 will pass 👍 |
Kane610
approved these changes
Jun 13, 2019
Merged
alandtse
pushed a commit
to alandtse/home-assistant
that referenced
this pull request
Oct 12, 2019
SeanPM5
added a commit
to home-assistant/home-assistant.io
that referenced
this pull request
Oct 6, 2020
1. Voice control used to work out of the box, but Conversation integration was removed from default_config over a year ago (home-assistant/core#24515), so these instructions were outdated. Updated the voice command part to clarify this relies on conversation integration being installed too. 2. Cross-linked to the Shopping List Lovelace card page 3. Removed the "click submit" and 'you'll get a success or error' part of instructions as I feel that is very obvious and unnecessary. This makes instructions a bit more concise. 4. Changed "Beer" example to "Milk" to be a tiny bit more kid friendly :)
8 tasks
frenck
pushed a commit
to home-assistant/home-assistant.io
that referenced
this pull request
Oct 15, 2020
1. Voice control used to work out of the box, but Conversation integration was removed from default_config over a year ago (home-assistant/core#24515), so these instructions were outdated. Updated the voice command part to clarify this relies on conversation integration being installed too. 2. Cross-linked to the Shopping List Lovelace card page 3. Removed the "click submit" and 'you'll get a success or error' part of instructions as I feel that is very obvious and unnecessary. This makes instructions a bit more concise. 4. Changed "Beer" example to "Milk" to be a tiny bit more kid friendly :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Breaking Change:
The conversation integration is no longer loaded as part of the default config. If you wish to continue using it, add
conversation:to your configuration.yaml.Description:
The conversation integration allows users to give voice commands via the frontend (the microphone button in Lovelace). It also allows people to configure their own custom sentences. However, this is barely used and the default settings are making it not a very useful feature.
I suggest that we retire it from the default config, and we can always add it back if it becomes more useful.