Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add radiotherm CT80 current humidity support #25024

Merged
merged 5 commits into from Jul 9, 2019
Merged

Add radiotherm CT80 current humidity support #25024

merged 5 commits into from Jul 9, 2019

Conversation

zombielinux
Copy link
Contributor

@zombielinux zombielinux commented Jul 8, 2019

Description:

Added a check for if device is a CT80, and if so, queries the humidity object to get the current measured humidity reading.

Pull request with documentation for home-assistant.io (if applicable): home-assistant/home-assistant.io#<home-assistant.io PR number goes here>

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly. Update and include derived files by running python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

If the code does not interact with devices:

  • Tests have been added to verify that the new code works.

Added a check for if device is a CT80, and if so, queries the humidity object to get the current measured humidity reading.
Removed whitespace on line 229
Copy link
Contributor

@elupus elupus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This can't be working. You don't actually add the humidity property anywhere.

Added humidity property. Version on local machine had that from previous tinkering.
@zombielinux
Copy link
Contributor Author

@elupus Good catch. I had that on my local machine, didn't get that copied over.

Removed whitespace
Fixed tstat error handling for humidity data.
@MartinHjelmare MartinHjelmare changed the title Added CT80 Current Humidity Support Add radiotherm CT80 current humidity support Jul 9, 2019
@MartinHjelmare
Copy link
Member

Can be merged when build passes.

@MartinHjelmare MartinHjelmare merged commit c5239c6 into home-assistant:dev Jul 9, 2019
@lock lock bot locked and limited conversation to collaborators Jul 10, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants