Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove monitored conditions from syncthru configuration #25052

Merged
merged 1 commit into from Jul 11, 2019

Conversation

nielstron
Copy link
Contributor

@nielstron nielstron commented Jul 10, 2019

Breaking Change:

The monitored_conditions configuration option has been removed. All available monitored conditions will be used by default. Users that have been using the monitored_conditions option need to remove it from the syncthru section in configuration.yaml.

Description:

As noted in this comment on my last PR monitored conditions are to be successively removed from home-assistant. Thus, now it is forbidden to use them anymore.
Removes the option of specifying monitored conditions in the syncthru component.

Pull request with documentation for home-assistant.io (if applicable): home-assistant/home-assistant.io#9825

Example entry for configuration.yaml (if applicable):

sensor:
  - platform: syncthru
    resource: http://my-printer.address
    name: My Awesome Printer

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly. Update and include derived files by running python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

Copy link
Member

@MartinHjelmare MartinHjelmare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Please write the breaking change paragraph so we can copy it directly to the release notes. It should mention what has changed and explain what the user needs to do to cope with the breaking change.

Eg:

The monitored_conditions configuration option has been removed. All available monitored conditions will be used by default. Users that have been using the monitored_conditions option need to remove it from the syncthru section in configuration.yaml.

You can add a link to the adr in the first sentence.

@nielstron
Copy link
Contributor Author

I have now simply copied your paragraph, including a link. Is it ok like that?

Copy link
Member

@MartinHjelmare MartinHjelmare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great!

Please rebase on latest dev branch to let the build pass.

@pvizeli pvizeli merged commit 71ddebb into home-assistant:dev Jul 11, 2019
@lock lock bot locked and limited conversation to collaborators Jul 12, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants