Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove monitored conditions from syncthru configuration #25052

Merged
merged 1 commit into from Jul 11, 2019

Conversation

@nielstron
Copy link
Contributor

commented Jul 10, 2019

Breaking Change:

The monitored_conditions configuration option has been removed. All available monitored conditions will be used by default. Users that have been using the monitored_conditions option need to remove it from the syncthru section in configuration.yaml.

Description:

As noted in this comment on my last PR monitored conditions are to be successively removed from home-assistant. Thus, now it is forbidden to use them anymore.
Removes the option of specifying monitored conditions in the syncthru component.

Pull request with documentation for home-assistant.io (if applicable): home-assistant/home-assistant.io#9825

Example entry for configuration.yaml (if applicable):

sensor:
  - platform: syncthru
    resource: http://my-printer.address
    name: My Awesome Printer

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly. Update and include derived files by running python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

@ghost ghost assigned nielstron Jul 10, 2019

@nielstron nielstron referenced this pull request Jul 10, 2019

Merged

Remove monitored conditions in syncthru component #9825

2 of 2 tasks complete

@nielstron nielstron force-pushed the nielstron:pysyncthru-patch-2 branch 2 times, most recently from 10cec7e to 6952139 Jul 10, 2019

@MartinHjelmare
Copy link
Member

left a comment

Thanks!

Please write the breaking change paragraph so we can copy it directly to the release notes. It should mention what has changed and explain what the user needs to do to cope with the breaking change.

Eg:

The monitored_conditions configuration option has been removed. All available monitored conditions will be used by default. Users that have been using the monitored_conditions option need to remove it from the syncthru section in configuration.yaml.

You can add a link to the adr in the first sentence.

@nielstron

This comment has been minimized.

Copy link
Contributor Author

commented Jul 10, 2019

I have now simply copied your paragraph, including a link. Is it ok like that?

@MartinHjelmare
Copy link
Member

left a comment

Great!

Please rebase on latest dev branch to let the build pass.

@nielstron nielstron force-pushed the nielstron:pysyncthru-patch-2 branch from 6952139 to 049a89a Jul 11, 2019

@pvizeli pvizeli merged commit 71ddebb into home-assistant:dev Jul 11, 2019

11 checks passed

build Workflow: build
Details
ci/circleci: pre-install-all-requirements Your tests passed on CircleCI!
Details
ci/circleci: pre-test 3.5.5 Your tests passed on CircleCI!
Details
ci/circleci: pre-test 3.6 Your tests passed on CircleCI!
Details
ci/circleci: pre-test 3.7 Your tests passed on CircleCI!
Details
ci/circleci: pylint Your tests passed on CircleCI!
Details
ci/circleci: static-check Your tests passed on CircleCI!
Details
ci/circleci: test 3.5.5 Your tests passed on CircleCI!
Details
ci/circleci: test 3.6 Your tests passed on CircleCI!
Details
ci/circleci: test 3.7 Your tests passed on CircleCI!
Details
cla-bot Everyone involved has signed the CLA

@lock lock bot locked and limited conversation to collaborators Jul 12, 2019

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
4 participants
You can’t perform that action at this time.