Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add migration notification for Ambient PWS #25561

Merged
merged 5 commits into from Jul 31, 2019

Conversation

bachya
Copy link
Contributor

@bachya bachya commented Jul 29, 2019

Description:

#25284 introduced a breaking change due to alterations in this integration's unique ID format. The PS4 integration gave me an inspiration: assuming that many people won't read the breaking change docs, it might be nice to automatically recreate it under the hood. This PR takes care of that.

Related issue (if applicable): N/A

Pull request with documentation for home-assistant.io (if applicable): N/A

Example entry for configuration.yaml (if applicable):

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist

@bachya bachya self-assigned this Jul 29, 2019
@project-bot project-bot bot added this to Needs review in Dev Jul 29, 2019
@bachya bachya added this to the 0.97.0 milestone Jul 29, 2019
@andrewsayre
Copy link
Member

No need to tag 0.97 given the beta cut from dev hasn't occurred yet. :)

@bachya bachya removed this from the 0.97.0 milestone Jul 29, 2019
@MartinHjelmare MartinHjelmare moved this from Needs review to Review in progress in Dev Jul 30, 2019
Dev automation moved this from Review in progress to Reviewer approved Jul 31, 2019
@balloob balloob merged commit 3a3f70e into home-assistant:dev Jul 31, 2019
Dev automation moved this from Reviewer approved to Done Jul 31, 2019
@bachya bachya deleted the ambient-notification branch July 31, 2019 17:32
@lock lock bot locked and limited conversation to collaborators Aug 1, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
Dev
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

4 participants