Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Python < 3.6 remainder cleanups #25607

Merged
merged 1 commit into from Jul 31, 2019
Merged

Python < 3.6 remainder cleanups #25607

merged 1 commit into from Jul 31, 2019

Conversation

scop
Copy link
Member

@scop scop commented Jul 31, 2019

Description:

Subject says it all.

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. (after Azure flake8 dep, docstring fixes #25605 they would I'm sure)
  • There is no commented out code in this PR.
  • I have followed the [development checklist][dev-checklist]

@scop scop requested a review from a team as a code owner July 31, 2019 19:13
@probot-home-assistant probot-home-assistant bot added core small-pr PRs with less than 30 lines. labels Jul 31, 2019
@project-bot project-bot bot added this to Needs review in Dev Jul 31, 2019
@@ -16,14 +16,14 @@ addons:
matrix:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should probably remove this file.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's very convenient to be able to run my own changes in CI. Travis works fine for that purpose, I don't know if Azure offers anything comparable. At least CircleCI didn't work well at all for me.

Dev automation moved this from Needs review to Reviewer approved Jul 31, 2019
@balloob balloob merged commit 3cf8964 into home-assistant:dev Jul 31, 2019
Dev automation moved this from Reviewer approved to Done Jul 31, 2019
@scop scop deleted the python36-cleanups branch July 31, 2019 19:27
@lock lock bot locked and limited conversation to collaborators Aug 1, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla-signed core small-pr PRs with less than 30 lines.
Projects
Dev
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

3 participants