Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

isort ZHA imports. #25660

Merged
merged 1 commit into from Aug 2, 2019
Merged

Conversation

Adminiuga
Copy link
Contributor

Description:

Addresses comments to #25644

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly. Update and include derived files by running python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

@project-bot project-bot bot added this to Needs review in Dev Aug 2, 2019
@ghost ghost assigned Adminiuga and dmulcahey Aug 2, 2019
@ghost
Copy link

ghost commented Aug 2, 2019

Hey there @dmulcahey, @Adminiuga, mind taking a look at this pull request as its been labeled with a integration (zha) you are listed as a codeowner for? Thanks!

This is a automatic comment generated by codeowners-mention to help ensure issues and pull requests are seen by the right people.

Dev automation moved this from Needs review to Reviewer approved Aug 2, 2019
@Adminiuga Adminiuga marked this pull request as ready for review August 2, 2019 14:23
@Adminiuga Adminiuga merged commit 0c561ae into home-assistant:dev Aug 2, 2019
Dev automation moved this from Reviewer approved to Done Aug 2, 2019
@Adminiuga Adminiuga deleted the ac/25644-comments branch August 2, 2019 14:37
@lock lock bot locked and limited conversation to collaborators Aug 3, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
Dev
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

3 participants