Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Azure mypy related tweaks #25663

Merged
merged 2 commits into from Aug 2, 2019

Conversation

@scop
Copy link
Contributor

commented Aug 2, 2019

Description:

Remove no longer needed debugging output, install -e . to get dependencies from setup.py installed (to match what tox does), fix/ignore one resulting typing issue.

scop added 2 commits Aug 2, 2019
Revert "Add some debugging to azure mypy job (#25632)"
This reverts commit 767b8e9.

No longer needed.
Install setup.py dependencies for mypy in Azure
For better coverage, and to match what tox does.

@scop scop requested a review from home-assistant/core as a code owner Aug 2, 2019

@project-bot project-bot bot added this to Needs review in Dev Aug 2, 2019

@scop

This comment has been minimized.

Copy link
Contributor Author

commented Aug 2, 2019

As discussed on discord with @pvizeli

@pvizeli
pvizeli approved these changes Aug 2, 2019

Dev automation moved this from Needs review to Reviewer approved Aug 2, 2019

@pvizeli pvizeli merged commit a2f9a52 into home-assistant:dev Aug 2, 2019

9 checks passed

CI Build #20190802.40 succeeded
Details
CI (FullCheck Mypy) FullCheck Mypy succeeded
Details
CI (FullCheck Pylint) FullCheck Pylint succeeded
Details
CI (Overview CheckFormat) Overview CheckFormat succeeded
Details
CI (Overview Lint) Overview Lint succeeded
Details
CI (Overview Validate) Overview Validate succeeded
Details
CI (Tests PyTest Python36) Tests PyTest Python36 succeeded
Details
CI (Tests PyTest Python37) Tests PyTest Python37 succeeded
Details
cla-bot Everyone involved has signed the CLA

Dev automation moved this from Reviewer approved to Done Aug 2, 2019

@scop scop deleted the scop:azure-mypy-deps branch Aug 2, 2019

@lock lock bot locked and limited conversation to collaborators Aug 3, 2019

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
3 participants
You can’t perform that action at this time.