Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Azure mypy related tweaks #25663

Merged
merged 2 commits into from Aug 2, 2019
Merged

Azure mypy related tweaks #25663

merged 2 commits into from Aug 2, 2019

Conversation

scop
Copy link
Member

@scop scop commented Aug 2, 2019

Description:

Remove no longer needed debugging output, install -e . to get dependencies from setup.py installed (to match what tox does), fix/ignore one resulting typing issue.

This reverts commit 767b8e9.

No longer needed.
For better coverage, and to match what tox does.
@scop scop requested a review from a team as a code owner August 2, 2019 14:50
@probot-home-assistant probot-home-assistant bot added core small-pr PRs with less than 30 lines. labels Aug 2, 2019
@project-bot project-bot bot added this to Needs review in Dev Aug 2, 2019
@scop
Copy link
Member Author

scop commented Aug 2, 2019

As discussed on discord with @pvizeli

Dev automation moved this from Needs review to Reviewer approved Aug 2, 2019
@pvizeli pvizeli merged commit a2f9a52 into home-assistant:dev Aug 2, 2019
Dev automation moved this from Reviewer approved to Done Aug 2, 2019
@scop scop deleted the azure-mypy-deps branch August 2, 2019 15:42
@lock lock bot locked and limited conversation to collaborators Aug 3, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla-signed core small-pr PRs with less than 30 lines.
Projects
Dev
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

3 participants