Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix deconz allow_clip_sensor and allow_deconz_groups options #25811

Merged
merged 2 commits into from Aug 9, 2019

Conversation

Anonym-tsk
Copy link
Contributor

@Anonym-tsk Anonym-tsk commented Aug 9, 2019

Description:

I found that options allow_clip_sensor and allow_deconz_groups in core.config_entries don't work.
It started from PR and async_populate_options function that moved these values from config_entry.data to config_entry.options.
According to this comment there is no way to change this options via UI.
But now they works and i can change them in core.config_entries.

Related issue (if applicable): fixes #

Pull request with documentation for home-assistant.io (if applicable): home-assistant/home-assistant.io#<home-assistant.io PR number goes here>

Example entry for configuration.yaml (if applicable):

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly. Update and include derived files by running python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

If the code does not interact with devices:

  • Tests have been added to verify that the new code works.

@probot-home-assistant
Copy link

Hey there @Kane610, mind taking a look at this pull request as its been labeled with a integration (deconz) you are listed as a codeowner for? Thanks!

@project-bot project-bot bot added this to Needs review in Dev Aug 9, 2019
@Kane610
Copy link
Member

Kane610 commented Aug 9, 2019

How could I have missed this? Thanks!

@Anonym-tsk
Copy link
Contributor Author

@Kane610 @balloob Please merge this PR to master if it's possible

Copy link
Member

@Kane610 Kane610 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this!

Dev automation moved this from Needs review to Reviewer approved Aug 9, 2019
@Kane610 Kane610 added this to the 0.97.1 milestone Aug 9, 2019
@Kane610 Kane610 merged commit 8b6ddc2 into home-assistant:dev Aug 9, 2019
Dev automation moved this from Reviewer approved to Done Aug 9, 2019
@balloob balloob mentioned this pull request Aug 9, 2019
@lock lock bot locked and limited conversation to collaborators Aug 10, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
Dev
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

4 participants