Add support Slide cover #25913
Merged
Add support Slide cover #25913
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
Fixed Removed other pylint warnings
|
Will anybody from the HA team will look into this PR? |
MartinHjelmare
requested changes
Aug 31, 2019
|
@MartinHjelmare I am reworking the init.py/cover.py/const.py at this moment and i will test the new code, before committing it again. I have replied to a few code reviews (the exception and login, aiohttp session, retry and timeout configuration items) |
Removed DOMAIN not exist check Changed if to min/max Changed 3rd party import to top of the module Removed timeout/retry parameters Removed unused constants Added check for discovery_info is none Changed pass slide object instead of full hass object Changed pass api object instead of full hass object Added unique_id functionality Removed entity_id/name properties Removed supported_features/state functions
MartinHjelmare
added
the
second-opinion-wanted
Changed Improved exception handling Changed Updated Slide API to 0.50.0
Changed retry setup into coroutine
balloob
removed
the
second-opinion-wanted
|
@MartinHjelmare I am still new with the process, but it looks like I don't have any open points/changed pending from my side? |
| except (goslideapi.ClientConnectionError, goslideapi.ClientTimeoutError) as err: | ||
| _LOGGER.error( | ||
| "Error connecting to Slide Cloud: %s, going to retry in %s seconds", | ||
| str(err), |
There was a problem hiding this comment.
The exception argument has a __str__ magic method.
Suggested change
| str(err), | |
| err, |
| async_call_later(hass, DEFAULT_RETRY, retry_setup) | ||
| return True | ||
|
|
||
| if result: |
There was a problem hiding this comment.
If we invert this check and log error and return False if true, we can outdent the debug log.
Suggested change
| if result: | |
| if not result: |
Changed invert if result to if not result
|
Can be merged when build passes. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Breaking Change:
None
Description:
Add support Slide cover integration (Cloud API).
Related issue (if applicable): None
Pull request with documentation for home-assistant.io (if applicable): home-assistant/home-assistant.io#10127
Example entry for
configuration.yaml(if applicable):Checklist:
tox. Your PR cannot be merged unless tests passIf user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
python3 -m script.hassfest.requirements_all.txtby runningpython3 -m script.gen_requirements_all..coveragerc.