Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix background crash in sisyphus integration #26032

Merged
merged 1 commit into from Aug 18, 2019

Conversation

jkeljo
Copy link
Contributor

@jkeljo jkeljo commented Aug 18, 2019

Description:

I think I was thinking in another language, since this was not valid Python. Result was that the thread that maintained the SocketIO connection to the table would die early on, so no status updates were actually flowing from the table.

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly. Update and include derived files by running python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

If the code does not interact with devices:

  • Tests have been added to verify that the new code works.

I think I was thinking in another language, since this was not valid Python. Result was that the thread that maintained the SocketIO connection to the table would die early on, so no status updates were actually flowing from the table.
@project-bot project-bot bot added this to Needs review in Dev Aug 18, 2019
@probot-home-assistant probot-home-assistant bot added integration: sisyphus small-pr PRs with less than 30 lines. labels Aug 18, 2019
Dev automation moved this from Needs review to Reviewer approved Aug 18, 2019
@andrewsayre andrewsayre merged commit 8da1879 into home-assistant:dev Aug 18, 2019
Dev automation moved this from Reviewer approved to Done Aug 18, 2019
@lock lock bot locked and limited conversation to collaborators Aug 19, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
Dev
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

3 participants