Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fritz device tracker: change 'Scanning' log entry to debug #26043

Merged
merged 1 commit into from Aug 18, 2019

Conversation

@ThaSiouL
Copy link
Contributor

commented Aug 18, 2019

Description:

I noticed that since I started using the Fritz device tracker one message made up 99% of my log. The info message 'Scanning' was logged up to 6 times per minute and bloated the log file.

Since I believe that this is not wanted behavior I changed the logging level for the polling of the fritz device tracker from info to debug.

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the [development checklist][dev-checklist]
Fritz device tracker: set 'scanning' log to debug
Changed the logging level for the polling of the fritz device tracker from info to debug.  The message was logged up to 6 times per minute and bloated the log file.
@homeassistant

This comment has been minimized.

Copy link
Contributor

commented Aug 18, 2019

Hi @ThaSiouL,

It seems you haven't yet signed a CLA. Please do so here.

Once you do that we will be able to review and accept this pull request.

Thanks!

@project-bot project-bot bot added this to Needs review in Dev Aug 18, 2019

@homeassistant homeassistant added cla-signed and removed cla-needed labels Aug 18, 2019

Dev automation moved this from Needs review to Reviewer approved Aug 18, 2019

@ThaSiouL ThaSiouL changed the title Fritz device tracker: change 'Scanning' log to debug Fritz device tracker: change 'Scanning' log entry to debug Aug 18, 2019

@Danielhiversen Danielhiversen merged commit 10d63e4 into home-assistant:dev Aug 18, 2019

12 checks passed

CI Build #20190818.28 succeeded
Details
CI (FullCheck Mypy) FullCheck Mypy succeeded
Details
CI (FullCheck Pylint) FullCheck Pylint succeeded
Details
CI (Overview CheckFormat) Overview CheckFormat succeeded
Details
CI (Overview Lint) Overview Lint succeeded
Details
CI (Overview Validate) Overview Validate succeeded
Details
CI (Tests PyTest Python36) Tests PyTest Python36 succeeded
Details
CI (Tests PyTest Python37) Tests PyTest Python37 succeeded
Details
cla-bot All contributors have signed the CLA
codecov/patch Coverage not affected when comparing 2a39d12...45de53a
Details
codecov/project 94.02% (target 90%)
Details
docs-missing Documentation ok.

Dev automation moved this from Reviewer approved to Done Aug 18, 2019

@ThaSiouL ThaSiouL deleted the ThaSiouL:patch-1 branch Aug 18, 2019

@lock lock bot locked and limited conversation to collaborators Aug 19, 2019

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
3 participants
You can’t perform that action at this time.