Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nissanleaf login fix #26139

Merged
merged 2 commits into from Aug 22, 2019

Conversation

@filcole
Copy link
Contributor

commented Aug 22, 2019

Breaking Change:

Nissan leaf European API no longer supports location control. The nissan_connect: element from the homeassistant nissan_leaf: configuration must be removed.

Description:

The Nissan Leaf European APIs changed on 25 July 2019 totally breaking the integration. This pull requests uses an updated pycarwings and homeassistant logic. The device tracker has been removed because the location control is no longer supported by Nissan.

Related issue (if applicable): fixes #24757

Pull request with documentation for home-assistant.io (if applicable): home-assistant/home-assistant.io#10207

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • [na] The manifest file has all fields filled out correctly. Update and include derived files by running python3 -m script.hassfest. SCRIPT BROKEN
  • New or updated dependencies have been added to requirements_all.txt by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

If the code does not interact with devices:

  • Tests have been added to verify that the new code works.
@balloob
Copy link
Member

left a comment

Looks good.

Dev automation moved this from Needs review to Reviewer approved Aug 22, 2019

@balloob balloob added this to the 0.98 milestone Aug 22, 2019

@balloob balloob merged commit bff5b00 into home-assistant:dev Aug 22, 2019

12 checks passed

CI Build #20190822.26 succeeded
Details
CI (FullCheck Mypy) FullCheck Mypy succeeded
Details
CI (FullCheck Pylint) FullCheck Pylint succeeded
Details
CI (Overview CheckFormat) Overview CheckFormat succeeded
Details
CI (Overview Lint) Overview Lint succeeded
Details
CI (Overview Validate) Overview Validate succeeded
Details
CI (Tests PyTest Python36) Tests PyTest Python36 succeeded
Details
CI (Tests PyTest Python37) Tests PyTest Python37 succeeded
Details
cla-bot Everyone involved has signed the CLA
codecov/patch Coverage not affected when comparing b3ae6a2...8d45939
Details
codecov/project 94% (target 90%)
Details
docs-missing Documentation ok.

Dev automation moved this from Reviewer approved to Done Aug 22, 2019

balloob added a commit that referenced this pull request Aug 23, 2019
Nissanleaf login fix (#26139)
* Upgrade to pycarwings2.9 per 25 July 2019 API change

* Remove rest of location tracker. Fix get_status_from_update call.

@lock lock bot locked and limited conversation to collaborators Aug 23, 2019

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
3 participants
You can’t perform that action at this time.