Nissanleaf login fix #26139
Merged
Nissanleaf login fix #26139
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
probot-home-assistant
bot
added
integration: nissan_leaf
remove-platform
small-pr
Merged
2 tasks
balloob
pushed a commit
that referenced
this pull request
Aug 23, 2019
* Upgrade to pycarwings2.9 per 25 July 2019 API change * Remove rest of location tracker. Fix get_status_from_update call.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Breaking Change:
Nissan leaf European API no longer supports location control. The
nissan_connect:element from the homeassistantnissan_leaf:configuration must be removed.Description:
The Nissan Leaf European APIs changed on 25 July 2019 totally breaking the integration. This pull requests uses an updated pycarwings and homeassistant logic. The device tracker has been removed because the location control is no longer supported by Nissan.
Related issue (if applicable): fixes #24757
Pull request with documentation for home-assistant.io (if applicable): home-assistant/home-assistant.io#10207
Checklist:
tox. Your PR cannot be merged unless tests passIf user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
python3 -m script.hassfest. SCRIPT BROKENrequirements_all.txtby runningpython3 -m script.gen_requirements_all..coveragerc.If the code does not interact with devices: