Fix flaky updater tests #26221
Merged
Fix flaky updater tests #26221
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
probot-home-assistant
bot
added
core
has-tests
small-pr
andrewsayre
commented
Aug 27, 2019
| """Fixture to mock utcnow.""" | ||
| with patch("homeassistant.components.updater.dt_util.utcnow") as mock: |
There was a problem hiding this comment.
This is where the root of the issue was. The tests weren't even using the fixture, probably because the patch wasn't working. I'm not sure why this didn't work (it does in other places in the tests, but none of those were in a fixture), but when debugging I could see it wasn't mocking. Changing it to the module then returning the method inside the yield fixed the issue.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Fixes an issue where
dt_util.utcnowwas not properly being patch in theupdatertests, which (I believe) resulted in periodic failures. Also updates the code in the file to use theasynckeywords and some linting. No functional changes to code.Related issue (if applicable): fixes #26187
Checklist:
tox. Your PR cannot be merged unless tests pass