Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use literal string interpolation in integrations T-W (f-strings) #26394

Merged
merged 1 commit into from Sep 3, 2019

Conversation

frenck
Copy link
Member

@frenck frenck commented Sep 3, 2019

Description:

Upgrades code to use string formatting using literal string interpolation format defined in PEP 498. Easier to read, generally smaller, and finally possible now 3.6 is the min version.

PEP 498: https://www.python.org/dev/peps/pep-0498

This PR converts code in integrations starting with the letter T, U,V and W.

⚠️ I expect codecov to fail on this one 🤷‍♂

Related issue (if applicable): n/a

Pull request with documentation for home-assistant.io (if applicable): n/a

Example entry for configuration.yaml (if applicable): n/a

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly. Update and include derived files by running python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

If the code does not interact with devices:

  • Tests have been added to verify that the new code works.

Dev automation moved this from Needs review to Reviewer approved Sep 3, 2019
@pvizeli pvizeli merged commit ef0e943 into dev Sep 3, 2019
Dev automation moved this from Reviewer approved to Done Sep 3, 2019
@delete-merged-branch delete-merged-branch bot deleted the frenck-2019-0178 branch September 3, 2019 19:12
@lock lock bot locked and limited conversation to collaborators Sep 4, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
Dev
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

3 participants