Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change datetime.now() to dt_util.now() #26582

Merged
merged 6 commits into from Sep 19, 2019

Conversation

@tsvi
Copy link
Contributor

commented Sep 11, 2019

Breaking Change:

Description:

These changes should not affect the functionality, rather cleanup our codebase.

In general we would like integrations to not to use datetime.now() unless there's a very good
reason for it, rather use our own dt_util.now() which makes the code aware of our current time
zone.

Related issue (if applicable): fixes #

Pull request with documentation for home-assistant.io (if applicable): home-assistant/home-assistant.io#<home-assistant.io PR number goes here>

Example entry for configuration.yaml (if applicable):

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly. Update and include derived files by running python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

If the code does not interact with devices:

  • Tests have been added to verify that the new code works.
@tsvi tsvi requested review from robbiet480 and home-assistant/core as code owners Sep 11, 2019
@project-bot project-bot bot added this to Needs review in Dev Sep 11, 2019
@tsvi tsvi force-pushed the tsvi:fix_datetime_now branch from 5f36463 to 6631fe9 Sep 12, 2019
tsvi added 3 commits Sep 11, 2019
…ty should stay the same

These changes should not affect the functionality, rather cleanup our codebase.

In general we would like integrations to not to use datetime.now() unless there's a very good
reason for it, rather use our own dt_util.now() which makes the code aware of our current time
zone.
…tc time"

This reverts commit 5f36463.
@tsvi tsvi force-pushed the tsvi:fix_datetime_now branch from 6631fe9 to d1fe64c Sep 15, 2019
@tsvi

This comment has been minimized.

Copy link
Contributor Author

commented Sep 16, 2019

@MartinHjelmare anything else I need to do here?

@MartinHjelmare MartinHjelmare moved this from Needs review to Review in progress in Dev Sep 17, 2019
tsvi added 2 commits Sep 18, 2019
Dev automation moved this from Review in progress to Reviewer approved Sep 19, 2019
Copy link
Member

left a comment

Great!

@MartinHjelmare

This comment has been minimized.

Copy link
Member

commented Sep 19, 2019

The coverage is failing since it's a small diff for covered files, and the relative coverage of the diff then gets below the total project coverage. Since we're not decreasing coverage per file the result isn't accurate in the bigger picture.

@MartinHjelmare MartinHjelmare changed the title Change datetime.now() to dt_util.now() - same functionality Change datetime.now() to dt_util.now() Sep 19, 2019
@MartinHjelmare MartinHjelmare merged commit 80136f3 into home-assistant:dev Sep 19, 2019
10 of 11 checks passed
10 of 11 checks passed
codecov/patch 93.75% of diff hit (target 93.98%)
Details
CI Build #20190919.2 succeeded
Details
CI (FullCheck Mypy) FullCheck Mypy succeeded
Details
CI (FullCheck Pylint) FullCheck Pylint succeeded
Details
CI (Overview CheckFormat) Overview CheckFormat succeeded
Details
CI (Overview Lint) Overview Lint succeeded
Details
CI (Overview Validate) Overview Validate succeeded
Details
CI (Tests PyTest Python36) Tests PyTest Python36 succeeded
Details
CI (Tests PyTest Python37) Tests PyTest Python37 succeeded
Details
cla-bot Everyone involved has signed the CLA
codecov/project 94% (target 90%)
Details
Dev automation moved this from Reviewer approved to Done Sep 19, 2019
@tsvi tsvi deleted the tsvi:fix_datetime_now branch Sep 19, 2019
@tsvi tsvi restored the tsvi:fix_datetime_now branch Sep 19, 2019
@tsvi tsvi deleted the tsvi:fix_datetime_now branch Sep 19, 2019
@lock lock bot locked and limited conversation to collaborators Sep 20, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
Dev
  
Done
3 participants
You can’t perform that action at this time.