New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add optimizer data to solaredge_local #26708
Conversation
Should the units for current and voltage be added in const.py |
We shouldn't add units in |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
Is it ready to merge? |
Not yet program fails when there was a bad connection to the inverter. |
We usually want to present the data as is from the device, but if the device sends data that isn't following best practices regarding significant figures, it's ok to round. Ie we shouldn't present numbers with false precision. |
There are no errors anymore when the inverter is not available. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good!
Description:
Added sensors for optimizer data.
Added sensor for inverter temperature.
Info
This is all the data received by the API
maintenance.log
power_control.log
status.log
information.log
My to-do list:
What to test
Problems
The solaredge-local api only gives current input in integers.
help needed for
Possible stuff people want to see.
Checklist:
tox
. Your PR cannot be merged unless tests passIf the code communicates with devices, web services, or third-party tools:
python3 -m script.hassfest
.requirements_all.txt
by runningpython3 -m script.gen_requirements_all
..coveragerc
.