Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unload Plex config entries #26771

Merged
merged 3 commits into from Sep 22, 2019

Conversation

@jjlawren
Copy link
Contributor

commented Sep 20, 2019

Description:

Properly unload removed Plex config entries. Followup from #26548.

Pull request with documentation for home-assistant.io (if applicable): home-assistant/home-assistant.io# N/A

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
@jjlawren jjlawren closed this Sep 21, 2019
Dev automation moved this from Needs review to Cancelled Sep 21, 2019
@jjlawren jjlawren reopened this Sep 21, 2019
Dev automation moved this from Cancelled to Needs review Sep 21, 2019
Dev automation moved this from Needs review to Reviewer approved Sep 21, 2019
@MartinHjelmare MartinHjelmare merged commit f82f30d into home-assistant:dev Sep 22, 2019
11 checks passed
11 checks passed
CI Build #20190921.23 succeeded
Details
CI (FullCheck Mypy) FullCheck Mypy succeeded
Details
CI (FullCheck Pylint) FullCheck Pylint succeeded
Details
CI (Overview CheckFormat) Overview CheckFormat succeeded
Details
CI (Overview Lint) Overview Lint succeeded
Details
CI (Overview Validate) Overview Validate succeeded
Details
CI (Tests PyTest Python36) Tests PyTest Python36 succeeded
Details
CI (Tests PyTest Python37) Tests PyTest Python37 succeeded
Details
cla-bot Everyone involved has signed the CLA
codecov/patch 100% of diff hit (target 94.05%)
Details
codecov/project 94.04% (target 90%)
Details
Dev automation moved this from Reviewer approved to Done Sep 22, 2019
@lock lock bot locked and limited conversation to collaborators Sep 23, 2019
@jjlawren jjlawren deleted the jjlawren:plex_unloading branch Sep 24, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
Dev
  
Done
3 participants
You can’t perform that action at this time.