Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add unit to 'charging_level_hv' bwm_connected_drive sensor #26861

Merged
merged 2 commits into from Sep 24, 2019

Conversation

@timmccor
Copy link
Contributor

commented Sep 23, 2019

Description:

This PR adds a unit to the 'charging_level_hv' sensor, which allows the UI to graph the values as a line graph rather than a bar graph of individual values.

Related issue (if applicable): fixes # n/a

Pull request with documentation for home-assistant.io (if applicable): home-assistant/home-assistant.io# n/a

Example entry for configuration.yaml (if applicable):

n/a

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
Add unit to charging_level_hv, which allows correct graphing in UI
@homeassistant

This comment has been minimized.

Copy link
Contributor

commented Sep 23, 2019

Hi @timmccor,

It seems you haven't yet signed a CLA. Please do so here.

Once you do that we will be able to review and accept this pull request.

Thanks!

Add space after #
Dev automation moved this from Needs review to Reviewer approved Sep 24, 2019
@MartinHjelmare MartinHjelmare changed the title Add unit to 'charging_level_hv' sensor Add unit to 'charging_level_hv' bwm_connected_drive sensor Sep 24, 2019
@MartinHjelmare MartinHjelmare merged commit 6fe5582 into home-assistant:dev Sep 24, 2019
1 check passed
1 check passed
cla-bot Everyone involved has signed the CLA
Dev automation moved this from Reviewer approved to Done Sep 24, 2019
@MartinHjelmare

This comment has been minimized.

Copy link
Member

commented Sep 24, 2019

Thanks!

@timmccor timmccor deleted the timmccor:add-battery-unit branch Sep 24, 2019
@lock lock bot locked and limited conversation to collaborators Sep 25, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
Dev
  
Done
3 participants
You can’t perform that action at this time.