Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix rest_command when server is unreachable #26948

Merged
merged 6 commits into from Sep 30, 2019

Commits on Sep 27, 2019

  1. fix rest_command when server is unreachable

    When a server doesn't exist, the connection fails immediately, rather
    than waiting for a timeout. This means that the async handler is never
    reached, and the request variable never filled, yet it's used in the
    client error exception handler, so this one bugs out.
    
    By using the command_config, we avoid using the potentially unassigned
    request variable, avoiding this problem.
    
    This patch makes scripts work that have a rest_command in them which
    fails due to a server being offline.
    sebasje committed Sep 27, 2019
    Copy the full SHA
    744c4a7 View commit details
    Browse the repository at this point in the history
  2. render template_url

    instead of printing the template object
    sebasje committed Sep 27, 2019
    Copy the full SHA
    830c2bc View commit details
    Browse the repository at this point in the history
  3. fix formatting

    sebasje committed Sep 27, 2019
    Copy the full SHA
    6b01058 View commit details
    Browse the repository at this point in the history
  4. fix format using black

    sebasje committed Sep 27, 2019
    Copy the full SHA
    16f2110 View commit details
    Browse the repository at this point in the history
  5. only render url once

    sebasje committed Sep 27, 2019
    Copy the full SHA
    96ec9b8 View commit details
    Browse the repository at this point in the history
  6. blacken...

    sebasje committed Sep 27, 2019
    Copy the full SHA
    85feca1 View commit details
    Browse the repository at this point in the history