Add create, remove of devices without a restart for HomematicIP_Cloud #27030
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
| async def async_create_entity_lazy(self, is_device=True): | ||
| """Delay entity creation to allow the user to enter a device name.""" | ||
| if is_device: | ||
| await asyncio.sleep(30) |
There was a problem hiding this comment.
Is there no callback when the user is done?
There was a problem hiding this comment.
No, there is no additional callback.
MartinHjelmare
approved these changes
Sep 28, 2019
|
Good point, i am already preparing tests. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This PR adds adds the ability to create and remove of HomematicIP devices and groups without restarting Homeassistant.
Pull request with documentation for home-assistant.io: home-assistant/home-assistant.io#10470
Checklist:
tox. Your PR cannot be merged unless tests passIf user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
python3 -m script.hassfest.requirements_all.txtby runningpython3 -m script.gen_requirements_all.