Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add create, remove of devices without a restart for HomematicIP_Cloud #27030

Merged
merged 1 commit into from Sep 28, 2019

Conversation

@SukramJ
Copy link
Contributor

commented Sep 28, 2019

Description:

This PR adds adds the ability to create and remove of HomematicIP devices and groups without restarting Homeassistant.

Pull request with documentation for home-assistant.io: home-assistant/home-assistant.io#10470

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly. Update and include derived files by running python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt by running python3 -m script.gen_requirements_all.
async def async_create_entity_lazy(self, is_device=True):
"""Delay entity creation to allow the user to enter a device name."""
if is_device:
await asyncio.sleep(30)

This comment has been minimized.

Copy link
@MartinHjelmare

MartinHjelmare Sep 28, 2019

Member

Is there no callback when the user is done?

This comment has been minimized.

Copy link
@SukramJ

SukramJ Sep 28, 2019

Author Contributor

No, there is no additional callback.

This comment has been minimized.

Copy link
@MartinHjelmare
Copy link
Member

left a comment

Looks good!

I advice you to start writing tests now that we're using more advanced logic in this integration.

Dev automation moved this from Needs review to Reviewer approved Sep 28, 2019
@SukramJ

This comment has been minimized.

Copy link
Contributor Author

commented Sep 28, 2019

Good point, i am already preparing tests.
I hope i can create a PR in the next 2 weeks.

@MartinHjelmare MartinHjelmare merged commit 61a7d8e into home-assistant:dev Sep 28, 2019
12 checks passed
12 checks passed
CI Build #20190928.9 succeeded
Details
CI (FullCheck Mypy) FullCheck Mypy succeeded
Details
CI (FullCheck Pylint) FullCheck Pylint succeeded
Details
CI (Overview CheckFormat) Overview CheckFormat succeeded
Details
CI (Overview Lint) Overview Lint succeeded
Details
CI (Overview Validate) Overview Validate succeeded
Details
CI (Tests PyTest Python36) Tests PyTest Python36 succeeded
Details
CI (Tests PyTest Python37) Tests PyTest Python37 succeeded
Details
cla-bot Everyone involved has signed the CLA
codecov/patch Coverage not affected when comparing 1c72a24...4656ac4
Details
codecov/project 94.24% (target 90%)
Details
docs-missing Documentation ok.
Dev automation moved this from Reviewer approved to Done Sep 28, 2019
@SukramJ SukramJ deleted the SukramJ:HmIP-create-remove branch Sep 29, 2019
@lock lock bot locked and limited conversation to collaborators Sep 30, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
Dev
  
Done
3 participants
You can’t perform that action at this time.