Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UniFi - Improve switch tests #27200

Merged
merged 2 commits into from Oct 5, 2019

Conversation

Kane610
Copy link
Member

@Kane610 Kane610 commented Oct 4, 2019

Breaking Change:

Description:

Related issue (if applicable): fixes #

Pull request with documentation for home-assistant.io (if applicable): home-assistant/home-assistant.io#<home-assistant.io PR number goes here>

Example entry for configuration.yaml (if applicable):

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly. Update and include derived files by running python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

If the code does not interact with devices:

  • Tests have been added to verify that the new code works.

@probot-home-assistant probot-home-assistant bot added has-tests small-pr PRs with less than 30 lines. labels Oct 4, 2019
@project-bot project-bot bot added this to Needs review in Dev Oct 4, 2019
@MartinHjelmare MartinHjelmare moved this from Needs review to Incoming in Dev Oct 4, 2019
Dev automation moved this from Incoming to Reviewer approved Oct 4, 2019
@Kane610 Kane610 marked this pull request as ready for review October 5, 2019 12:32
@Kane610 Kane610 self-assigned this Oct 5, 2019
@Kane610 Kane610 merged commit a8567a7 into home-assistant:dev Oct 5, 2019
Dev automation moved this from Reviewer approved to Done Oct 5, 2019
@Kane610 Kane610 deleted the unifi-improve_switch_tests branch October 5, 2019 14:16
@lock lock bot locked and limited conversation to collaborators Oct 6, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
Dev
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

4 participants