Fix for ecobee unknown sensor state #27542
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
probot-home-assistant
bot
added
integration: ecobee
small-pr
balloob
reviewed
Oct 12, 2019
| @@ -112,7 +112,7 @@ def device_class(self): | |||
| @property | |||
| def state(self): | |||
| """Return the state of the sensor.""" | |||
| if self._state in [ECOBEE_STATE_CALIBRATING, ECOBEE_STATE_UNKNOWN]: | |||
| if self._state in [ECOBEE_STATE_CALIBRATING, ECOBEE_STATE_UNKNOWN, "unknown"]: | |||
There was a problem hiding this comment.
Should this become part of PYECOBEE ?
There was a problem hiding this comment.
For sure it should. There are a bunch of additions to pyecobee I want to make when the dust has settled on the changes in HA.
balloob
approved these changes
Oct 12, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
The sensor platform was not catching all possible return values from the ecobee API for processing, resulting in the issue which this PR fixes. Now also catch the returned value "unknown". Also rewrote the async_update method to add guard clauses for greater efficiency in returning the state value.
Should be considered for a point release.
Related issue (if applicable): fixes #27489
Pull request with documentation for home-assistant.io (if applicable): N/A
Example entry for
configuration.yaml(if applicable):N/A
Checklist:
tox. Your PR cannot be merged unless tests passIf user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
python3 -m script.hassfest.requirements_all.txtby runningpython3 -m script.gen_requirements_all..coveragerc.If the code does not interact with devices: