Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move imports in darksky component #27633

Merged
merged 3 commits into from Oct 14, 2019
Merged

Conversation

exxamalte
Copy link
Contributor

@exxamalte exxamalte commented Oct 14, 2019

Breaking Change:

Description:

Moved imports from functions to top-level as requested in #27284

Related issue (if applicable): #27284

Pull request with documentation for home-assistant.io (if applicable): n/a

Example entry for configuration.yaml (if applicable): n/a

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist

If the code does not interact with devices:

  • Tests have been added to verify that the new code works.

@probot-home-assistant
Copy link

Hey there @fabaff, mind taking a look at this pull request as its been labeled with a integration (darksky) you are listed as a codeowner for? Thanks!

@fabaff
Copy link
Member

fabaff commented Oct 14, 2019

Duplicate of #27504

@fabaff fabaff marked this as a duplicate of #27504 Oct 14, 2019
@exxamalte
Copy link
Contributor Author

Ops, didn't see that there was already an open PR for this.
Well, this one comes with working unit tests :)

@pvizeli pvizeli merged commit 91c6cd9 into home-assistant:dev Oct 14, 2019
Dev automation moved this from Needs review to Done Oct 14, 2019
@exxamalte exxamalte deleted the imports-darksky branch October 14, 2019 21:49
@lock lock bot locked and limited conversation to collaborators Oct 15, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
Dev
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

4 participants