Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update fritzconnection requirement to 0.8.4 #27698

Merged
merged 2 commits into from Oct 15, 2019
Merged

Update fritzconnection requirement to 0.8.4 #27698

merged 2 commits into from Oct 15, 2019

Conversation

AaronDavidSchneider
Copy link
Contributor

@AaronDavidSchneider AaronDavidSchneider commented Oct 15, 2019

Breaking Change:

Update of requirements

Description:

Using different fritzbox components together leads to problems regarding the version of fritzconnection installed in homeassistant. We encountered this problem, when using our custom component:
https://github.com/mammuth/ha-fritzbox-tools/issues/19

See also #27691 and #27699

**Related issue (if applicable):

**Pull request with documentation for home-assistant.io (if applicable):

Example entry for configuration.yaml (if applicable):

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. (not tested yet)
  • There is no commented out code in this PR.
  • I have followed the development checklist

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly. Update and include derived files by running python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

If the code does not interact with devices:

  • Tests have been added to verify that the new code works.

@MartinHjelmare MartinHjelmare changed the title update fritzconnection requirement to 0.8.4 Update fritzconnection requirement to 0.8.4 Oct 15, 2019
@fabaff
Copy link
Member

fabaff commented Oct 15, 2019

Using different fritzbox components together leads to problems regarding the version of fritzconnection installed in homeassistant. We encountered this problem, when using our custom component:
mammuth/ha-fritzbox-tools#19

This will not solve the issue mentioned because the release is pinned there to 0.8.2. It will also require that the custom component gets an upgrade.

@AaronDavidSchneider
Copy link
Contributor Author

Using different fritzbox components together leads to problems regarding the version of fritzconnection installed in homeassistant. We encountered this problem, when using our custom component:
mammuth/ha-fritzbox-tools#19

This will not solve the issue mentioned because the release is pinned there to 0.8.2. It will also require that the custom component gets an upgrade.

Thank you, I created a pull request.

@AaronDavidSchneider
Copy link
Contributor Author

@fabaff: our custom_component uses now version 0.8.4.

Dev automation moved this from Needs review to Reviewer approved Oct 15, 2019
@pvizeli pvizeli merged commit d534f30 into home-assistant:dev Oct 15, 2019
Dev automation moved this from Reviewer approved to Done Oct 15, 2019
@lock lock bot locked and limited conversation to collaborators Oct 16, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
Dev
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

4 participants