Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix On/Off for melissa #27733

Merged
merged 2 commits into from Oct 17, 2019
Merged

Fix On/Off for melissa #27733

merged 2 commits into from Oct 17, 2019

Conversation

kennedyshead
Copy link
Contributor

Description:
State has to be set in order for the component to turn on

Related issue (if applicable): fixes #27092

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the [development checklist][dev-checklist]

@project-bot project-bot bot added this to Needs review in Dev Oct 16, 2019
@project-bot project-bot bot moved this from Needs review to By Code Owner in Dev Oct 16, 2019
@MartinHjelmare MartinHjelmare changed the title Fixed On/Off for melissa Fix On/Off for melissa Oct 17, 2019
Dev automation moved this from By Code Owner to Review in progress Oct 17, 2019
MartinHjelmare
MartinHjelmare requested changes Oct 17, 2019
View reviewed changes
Copy link
Member

@MartinHjelmare MartinHjelmare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please run black code formatter from the project root.

black --fast homeassistant

MartinHjelmare
MartinHjelmare approved these changes Oct 17, 2019
View reviewed changes
Copy link
Member

@MartinHjelmare MartinHjelmare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Dev automation moved this from Review in progress to Reviewer approved Oct 17, 2019
@MartinHjelmare MartinHjelmare merged commit 46f1166 into home-assistant:dev Oct 17, 2019
Dev automation moved this from Reviewer approved to Done Oct 17, 2019
@lock lock bot locked and limited conversation to collaborators Oct 18, 2019
@kennedyshead kennedyshead deleted the melissa_fix branch October 29, 2019 11:28
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@MartinHjelmare MartinHjelmare MartinHjelmare approved these changes

Assignees
No one assigned
Labels
by-code-owner cla-signed Hacktoberfest integration: melissa small-pr PRs with less than 30 lines.
Projects
Dev
  
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Climate - Melissa - turn_on doesn't work
4 participants
@kennedyshead @MartinHjelmare @homeassistant @MagnusKnutas