Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move imports in mqtt component #27835

Merged
merged 5 commits into from Oct 18, 2019
Merged

Move imports in mqtt component #27835

merged 5 commits into from Oct 18, 2019

Conversation

exxamalte
Copy link
Contributor

@exxamalte exxamalte commented Oct 17, 2019 •
edited

Breaking Change:

Description:

Moved imports from functions to top-level as requested in #27284

Related issue (if applicable): #27284

Pull request with documentation for home-assistant.io (if applicable): n/a

Example entry for configuration.yaml (if applicable): n/a

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist

If the code does not interact with devices:

  • Tests have been added to verify that the new code works.

@exxamalte exxamalte requested a review from a team as a code owner October 17, 2019 21:58
@project-bot project-bot bot added this to Needs review in Dev Oct 17, 2019
@probot-home-assistant
Copy link

Hey there @home-assistant/core, mind taking a look at this pull request as its been labeled with a integration (mqtt) you are listed as a codeowner for? Thanks!

Dev automation moved this from Needs review to Reviewer approved Oct 18, 2019
balloob
balloob approved these changes Oct 18, 2019
View reviewed changes
Copy link
Member

@balloob balloob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@balloob balloob merged commit 1a5b4c1 into home-assistant:dev Oct 18, 2019
Dev automation moved this from Reviewer approved to Done Oct 18, 2019
@exxamalte exxamalte deleted the imports-mqtt branch October 18, 2019 07:56
@lock lock bot locked and limited conversation to collaborators Oct 19, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@balloob balloob balloob approved these changes

Assignees
No one assigned
Labels
cla-signed core Hacktoberfest has-tests integration: mqtt new-platform
Projects
Dev
  
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@exxamalte @balloob @homeassistant