Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for AdGuard Home v0.99.0 #27926

Merged
merged 4 commits into from Oct 19, 2019
Merged

Add support for AdGuard Home v0.99.0 #27926

merged 4 commits into from Oct 19, 2019

Conversation

frenck
Copy link
Member

@frenck frenck commented Oct 19, 2019

Breaking Change:

The AdGuard Home integration has been made compatible with AdGuard Home v0.99.0. However, support for lower versions is now limited. Upgrading to AdGuard Home v0.99.0 or newer is advised.

Description:

AdGuard Home introduced some significant API changes (and bugs) in version v0.99.0.
This bump addressed these. However, it would cause an instant drop in support older version.

Release notes: https://github.com/frenck/python-adguardhome/releases/tag/v0.3.0

Related issue (if applicable): fixes #27918

Pull request with documentation for home-assistant.io (if applicable): n/a

Example entry for configuration.yaml (if applicable):

n/a

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist

If user exposed functionality or configuration variables are added/changed:
馃毇 Documentation added/updated in home-assistant.io

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly. Update and include derived files by running python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt by running python3 -m script.gen_requirements_all.
    馃毇 Untested files have been added to .coveragerc.

If the code does not interact with devices:

  • Tests have been added to verify that the new code works.

@project-bot project-bot bot added this to Needs review in Dev Oct 19, 2019
@project-bot project-bot bot moved this from Needs review to By Code Owner in Dev Oct 19, 2019
Dev automation moved this from By Code Owner to Reviewer approved Oct 19, 2019
@pvizeli
Copy link
Member

pvizeli commented Oct 19, 2019

Maybe you can ask API version and show a warning?

@frenck frenck changed the title Bump adguardhome to 0.3.0 WIP: Bump adguardhome to 0.3.0 Oct 19, 2019
@frenck
Copy link
Member Author

frenck commented Oct 19, 2019

Thanks, @pvizeli, good feedback.

  • Added logs
  • Added feedback/handling in the config flow for manual setup
  • Added feedback/handling in the config flow for Hass.io add-ons
  • Updated tests.

image
The spelling error in this screenshot has been fixed.

@frenck frenck changed the title WIP: Bump adguardhome to 0.3.0 Bump adguardhome to 0.3.0 Oct 19, 2019
@frenck frenck changed the title Bump adguardhome to 0.3.0 Add support for AdGuard Home v0.99.0 Oct 19, 2019
@frenck frenck moved this from Reviewer approved to By Code Owner in Dev Oct 19, 2019
Copy link
Contributor

@cgtobi cgtobi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Dev automation moved this from By Code Owner to Reviewer approved Oct 19, 2019
@balloob balloob merged commit cb061e5 into dev Oct 19, 2019
Dev automation moved this from Reviewer approved to Done Oct 19, 2019
@delete-merged-branch delete-merged-branch bot deleted the frenck-2019-0247 branch October 19, 2019 19:11
@lock lock bot locked and limited conversation to collaborators Oct 20, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
Dev
  
Done
Development

Successfully merging this pull request may close these issues.

AdGuard Home v0.99.0 breaks integration
6 participants