New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for AdGuard Home v0.99.0 #27926
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
probot-home-assistant
bot
added
integration: adguard
small-pr
PRs with less than 30 lines.
dependency
by-code-owner
labels
Oct 19, 2019
pvizeli
approved these changes
Oct 19, 2019
Maybe you can ask API version and show a warning? |
andrewsayre
approved these changes
Oct 19, 2019
Thanks, @pvizeli, good feedback.
|
frenck
changed the title
Bump adguardhome to 0.3.0
Add support for AdGuard Home v0.99.0
Oct 19, 2019
cgtobi
reviewed
Oct 19, 2019
cgtobi
approved these changes
Oct 19, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
breaking-change
by-code-owner
cla-signed
dependency
Hacktoberfest
integration: adguard
small-pr
PRs with less than 30 lines.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Breaking Change:
The AdGuard Home integration has been made compatible with AdGuard Home v0.99.0. However, support for lower versions is now limited. Upgrading to AdGuard Home v0.99.0 or newer is advised.
Description:
AdGuard Home introduced some significant API changes (and bugs) in version v0.99.0.
This bump addressed these. However, it would cause an instant drop in support older version.
Release notes: https://github.com/frenck/python-adguardhome/releases/tag/v0.3.0
Related issue (if applicable): fixes #27918
Pull request with documentation for home-assistant.io (if applicable): n/a
Example entry for
configuration.yaml
(if applicable):n/a
Checklist:
tox
. Your PR cannot be merged unless tests passIf user exposed functionality or configuration variables are added/changed:
馃毇 Documentation added/updated in home-assistant.io
If the code communicates with devices, web services, or third-party tools:
python3 -m script.hassfest
.requirements_all.txt
by runningpython3 -m script.gen_requirements_all
.馃毇 Untested files have been added to
.coveragerc
.If the code does not interact with devices: